linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	hannes@cmpxchg.org, iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
	mhocko@suse.com, minchan@kernel.org, mm-commits@vger.kernel.org,
	riel@surriel.com, torvalds@linux-foundation.org
Subject: Re: [patch 113/131] mm: balance LRU lists based on relative thrashing
Date: Tue, 9 Jun 2020 17:15:33 +0800	[thread overview]
Message-ID: <a60f7866-3b32-7a0e-5d0a-a48d77f845a8@linux.alibaba.com> (raw)
In-Reply-To: <20200603230303.kSkT62Lb5%akpm@linux-foundation.org>



在 2020/6/4 上午7:03, Andrew Morton 写道:
>  
> +	/* XXX: Move to lru_cache_add() when it supports new vs putback */

Hi Hannes,

Sorry for a bit lost, would you like to explain a bit more of your idea here?

> +	spin_lock_irq(&page_pgdat(page)->lru_lock);
> +	lru_note_cost(page);
> +	spin_unlock_irq(&page_pgdat(page)->lru_lock);
> +


What could we see here w/o the lru_lock?

Thanks
Alex

       reply	other threads:[~2020-06-09  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200603230303.kSkT62Lb5%akpm@linux-foundation.org>
2020-06-09  9:15 ` Alex Shi [this message]
2020-06-09 14:45   ` [patch 113/131] mm: balance LRU lists based on relative thrashing Johannes Weiner
2020-06-10  5:23     ` Joonsoo Kim
2020-06-11  3:28       ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a60f7866-3b32-7a0e-5d0a-a48d77f845a8@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=riel@surriel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).