From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Arnd Bergmann <arnd@kernel.org>
Cc: luojiaxing <luojiaxing@huawei.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
"open list:GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>,
linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxarm@openeuler.org" <linuxarm@openeuler.org>
Subject: RE: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()
Date: Fri, 12 Feb 2021 05:05:51 +0000 [thread overview]
Message-ID: <a61ef337fd1c4538a47fe855920f95d3@hisilicon.com> (raw)
In-Reply-To: <d5465b81-bb53-49ee-a556-40d208deb765@ti.com>
> -----Original Message-----
> From: Grygorii Strashko [mailto:grygorii.strashko@ti.com]
> Sent: Friday, February 12, 2021 9:17 AM
> To: Arnd Bergmann <arnd@kernel.org>
> Cc: luojiaxing <luojiaxing@huawei.com>; Linus Walleij
> <linus.walleij@linaro.org>; Andy Shevchenko <andy.shevchenko@gmail.com>; Andy
> Shevchenko <andriy.shevchenko@linux.intel.com>; Santosh Shilimkar
> <ssantosh@kernel.org>; Kevin Hilman <khilman@kernel.org>; open list:GPIO
> SUBSYSTEM <linux-gpio@vger.kernel.org>, linux-kernel@vger.kernel.org
> <linux-kernel@vger.kernel.org>; linuxarm@openeuler.org
> Subject: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace
> raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler()
>
>
>
> On 11/02/2021 21:39, Arnd Bergmann wrote:
> > On Thu, Feb 11, 2021 at 7:25 PM Grygorii Strashko
> > <grygorii.strashko@ti.com> wrote:
> >> On 08/02/2021 10:56, Luo Jiaxing wrote:
> >>> There is no need to use API with _irqsave in omap_gpio_irq_handler(),
> >>> because it already be in a irq-disabled context.
> >>
> >> NACK.
> >> Who said that this is always hard IRQ handler?
> >> What about RT-kernel or boot with "threadirqs"?
> >
> > In those cases, the interrupt handler is just a normal thread, so the
> > preempt_disable() that is implied by raw_spin_lock() is sufficient.
> >
> > Disabling interrupts inside of an interrupt handler is always incorrect,
> > the patch looks like a useful cleanup to me, if only for readability.
>
> Note. there is also generic_handle_irq() call inside.
So generic_handle_irq() is not safe to run in thread thus requires
an interrupt-disabled environment to run? If so, I'd rather this
irqsave moved into generic_handle_irq() rather than asking everyone
calling it to do irqsave.
On the other hand, the author changed a couple of spin_lock_irqsave
to spin_lock, if only this one is incorrect, it seems it is worth a
new version to fix this.
>
> --
> Best regards,
> grygorii
Thanks
Barry
next prev parent reply other threads:[~2021-02-12 5:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 8:56 [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock Luo Jiaxing
2021-02-08 8:56 ` [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler() Luo Jiaxing
2021-02-11 18:14 ` Grygorii Strashko
2021-02-11 19:39 ` Arnd Bergmann
2021-02-11 20:16 ` Grygorii Strashko
2021-02-12 5:05 ` Song Bao Hua (Barry Song) [this message]
2021-02-12 9:45 ` [Linuxarm] " Arnd Bergmann
2021-02-12 10:25 ` Song Bao Hua (Barry Song)
2021-02-12 10:27 ` Grygorii Strashko
2021-02-12 10:42 ` Song Bao Hua (Barry Song)
2021-02-12 10:57 ` Andy Shevchenko
2021-02-12 11:29 ` Song Bao Hua (Barry Song)
2021-02-12 11:53 ` Grygorii Strashko
2021-02-12 13:12 ` Song Bao Hua (Barry Song)
2021-02-12 14:08 ` Grygorii Strashko
2021-02-12 20:06 ` Song Bao Hua (Barry Song)
2021-02-12 20:23 ` Arnd Bergmann
2021-02-12 20:49 ` Song Bao Hua (Barry Song)
2021-02-12 10:59 ` Arnd Bergmann
2021-02-12 11:35 ` Andy Shevchenko
2021-02-08 9:11 ` [Linuxarm] [PATCH for next v1 0/2] gpio: few clean up patches to replace spin_lock_irqsave with spin_lock luojiaxing
2021-02-08 13:28 ` Andy Shevchenko
2021-02-09 9:24 ` luojiaxing
2021-02-09 9:42 ` Andy Shevchenko
2021-02-10 3:43 ` luojiaxing
2021-02-10 10:50 ` Andy Shevchenko
2021-02-10 11:50 ` [Linuxarm] " Song Bao Hua (Barry Song)
2021-02-10 14:56 ` Andy Shevchenko
2021-02-10 20:42 ` Song Bao Hua (Barry Song)
2021-02-11 9:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a61ef337fd1c4538a47fe855920f95d3@hisilicon.com \
--to=song.bao.hua@hisilicon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=luojiaxing@huawei.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).