From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Chintan Pandya <cpandya@codeaurora.org>,
vbabka@suse.cz, labbott@redhat.com, catalin.marinas@arm.com,
hannes@cmpxchg.org, f.fainelli@gmail.com, xieyisheng1@huawei.com,
ard.biesheuvel@linaro.org, richard.weiyang@gmail.com,
byungchul.park@lge.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmalloc: Remove double execution of vunmap_page_range
Date: Fri, 13 Apr 2018 15:29:41 +0530 [thread overview]
Message-ID: <a623e12b-bb5e-58fa-c026-de9ea53c5bd9@linux.vnet.ibm.com> (raw)
In-Reply-To: <1523611019-17679-1-git-send-email-cpandya@codeaurora.org>
On 04/13/2018 02:46 PM, Chintan Pandya wrote:
> Unmap legs do call vunmap_page_range() irrespective of
> debug_pagealloc_enabled() is enabled or not. So, remove
> redundant check and optional vunmap_page_range() routines.
vunmap_page_range() tears down the page table entries and does
not really flush related TLB entries normally unless page alloc
debug is enabled where it wants to make sure no stale mapping is
still around for debug purpose. Deferring TLB flush improves
performance. This patch will force TLB flush during each page
table tear down and hence not desirable.
next prev parent reply other threads:[~2018-04-13 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 9:16 [PATCH] mm: vmalloc: Remove double execution of vunmap_page_range Chintan Pandya
2018-04-13 9:59 ` Anshuman Khandual [this message]
2018-04-13 10:17 ` Chintan Pandya
2018-04-13 10:40 ` Anshuman Khandual
2018-04-13 10:45 ` Chintan Pandya
2018-04-13 11:09 ` Michal Hocko
2018-04-13 11:27 ` Chintan Pandya
2018-04-13 11:41 ` Michal Hocko
2018-04-13 12:12 ` Chintan Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a623e12b-bb5e-58fa-c026-de9ea53c5bd9@linux.vnet.ibm.com \
--to=khandual@linux.vnet.ibm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=byungchul.park@lge.com \
--cc=catalin.marinas@arm.com \
--cc=cpandya@codeaurora.org \
--cc=f.fainelli@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=vbabka@suse.cz \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).