From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF70C433E9 for ; Mon, 8 Mar 2021 21:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECF1065238 for ; Mon, 8 Mar 2021 21:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230440AbhCHVVB (ORCPT ); Mon, 8 Mar 2021 16:21:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhCHVUp (ORCPT ); Mon, 8 Mar 2021 16:20:45 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E977C06174A for ; Mon, 8 Mar 2021 13:20:45 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id y124-20020a1c32820000b029010c93864955so4667689wmy.5 for ; Mon, 08 Mar 2021 13:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wu9oEK/xAOW3gNEBHL714OoOhpYk6t+OPca6LRUekWk=; b=l+N+aBZyBLQ84Xc2qonMKfPS7O2smDSRBs6+j/Tq2b3Ps9waqqMvbHOyDBtXY7n7n1 h/7wW0CY7KT571n+Z4GG4Zyqv0isfcXDMwhXnbptQzeon+Ta6g1motpUHYUN3esxRyGt x6TMzBHcCdnqkAEGDvHJeikOnGZypc4Px8eOHjOW2iW5aYbdJbC3m+9JtZEPbDlkVv5A bNeqEg01ga04gIcbpSUfuH+h9xK9if5xYdqX8zwjb0JFOPKr2gfiUPCif1GMepnctB5C Aposko2oQsUOU5tEt6caJTYEAQ+CQ3y2nnJGP7L0BTwptJelxdjUrtOsJVlq5LO2fy/d 3QXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wu9oEK/xAOW3gNEBHL714OoOhpYk6t+OPca6LRUekWk=; b=uklpCxKTMMwC8H/qLAGvYxcb8LeLTEjlRqS216IHiUTkYzilbCJka0fM+6gBsUxP0J 4Aamc8FjptrveDG8UvmzpkA9CQ5DN372XQHCfFumDa146x8TszWDro1sMsJLjsqmJCE8 5q70/GDgw9rVd0cJbPphGni5DvGXfXBLh23Ld6FGaY9yVY6LQHrDT6DFESdBxZ3fN7+f Hv2RDeWP4iL50rmSuTOAlqLraLLjeksTZe01e/FLMq35lEX9rRuoWpA91pyRTZJZC3Bv Z1oD4B8lpYoHtS9N+fCF+zlvftCOErep+0JU5f5/F/qXyiMANxY6FbESPDOxX1WLPBn9 o4NA== X-Gm-Message-State: AOAM533w2HXiT7ZMWzgedpLYYAdxILNvYy6LGA18yioO4qEZVl8CMwuE dQnHIPI8BHUcSgD1GP/6FdffPA== X-Google-Smtp-Source: ABdhPJx4Cn7xkmyuZRQVCSGlOMwAkEiRCQzXKjWNe05h+eRzWC3kXIdu9sKh+xq62pqoDghjIdy2eA== X-Received: by 2002:a7b:c2a9:: with SMTP id c9mr683024wmk.116.1615238444034; Mon, 08 Mar 2021 13:20:44 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:8499:4f69:106b:da0? ([2a01:e34:ed2f:f020:8499:4f69:106b:da0]) by smtp.googlemail.com with ESMTPSA id k12sm15190906wrx.7.2021.03.08.13.20.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 13:20:43 -0800 (PST) Subject: Re: [PATCH 1/5] powercap/drivers/dtpm: Encapsulate even more the code To: Lukasz Luba , rafael@kernel.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20210301212149.22877-1-daniel.lezcano@linaro.org> <2d5e7eff-ae9d-2c67-3f49-89cb006b4a1b@arm.com> From: Daniel Lezcano Message-ID: Date: Mon, 8 Mar 2021 22:20:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2d5e7eff-ae9d-2c67-3f49-89cb006b4a1b@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2021 20:55, Lukasz Luba wrote: > Hi Daniel, > > On 3/8/21 7:31 PM, Daniel Lezcano wrote: >> >> On 01/03/2021 22:21, Daniel Lezcano wrote: >>> In order to increase the self-encapsulation of the dtpm generic code, >>> the following changes are adding a power update ops to the dtpm >>> ops. That allows the generic code to call directly the dtpm backend >>> function to update the power values. >>> >>> The power update function does compute the power characteristics when >>> the function is invoked. In the case of the CPUs, the power >>> consumption depends on the number of online CPUs. The online CPUs mask >>> is not up to date at CPUHP_AP_ONLINE_DYN state in the tear down >>> callback. That is the reason why the online / offline are at separate >>> state. As there is already an existing state for DTPM, this one is >>> only moved to the DEAD state, so there is no addition of new state >>> with these changes. >>> >>> That simplifies the code for the next changes and results in a more >>> self-encapsulated code. >>> >>> Signed-off-by: Daniel Lezcano >> >> Is there any comment on this series ? > > If you can wait 1 day, I will review it tomorrow... Sure, thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog