linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [PATCH v2] v4l: Add source event change for bit-depth
Date: Wed, 8 May 2019 18:38:49 +0200	[thread overview]
Message-ID: <a63d1c5f-806e-92c3-a6f7-e70f0686a27d@xs4all.nl> (raw)
In-Reply-To: <d6dcee9a-0308-855c-9819-3e7413cb617d@linaro.org>

On 5/8/19 5:34 PM, Stanimir Varbanov wrote:
> Hi Hans,
> 
> On 5/8/19 2:37 PM, Stanimir Varbanov wrote:
>> This event indicate that the source bit-depth is changed during
>> run-time. The client must get the new format and re-allocate buffers
>> for it. This can usually happens with video decoder (encoders) when
>> the bit-stream depth is changed from 8 to 10bits or vice versa.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>> Change since v1: s/BITDEPTH/BIT_DEPTH
>>
>>  Documentation/media/uapi/v4l/vidioc-dqevent.rst | 7 +++++++
>>  Documentation/media/videodev2.h.rst.exceptions  | 1 +
>>  include/uapi/linux/videodev2.h                  | 1 +
>>  3 files changed, 9 insertions(+)
>>
>> diff --git a/Documentation/media/uapi/v4l/vidioc-dqevent.rst b/Documentation/media/uapi/v4l/vidioc-dqevent.rst
>> index dea9c0cc00ab..f7782cbddc5f 100644
>> --- a/Documentation/media/uapi/v4l/vidioc-dqevent.rst
>> +++ b/Documentation/media/uapi/v4l/vidioc-dqevent.rst
>> @@ -397,6 +397,13 @@ call.
>>  	that many devices are not able to recover from a temporary loss of
>>  	signal and so restarting streaming I/O is required in order for the
>>  	hardware to synchronize to the video signal.
>> +    * - ``V4L2_EVENT_SRC_CH_BIT_DEPTH``
> 
> I started to wonder isn't COLOR_DEPTH more appropriate? Bit-depth
> doesn't describe what is actually deep.
> 

I agree. COLOR_DEPTH is a better name.

Regards,

	Hans

  reply	other threads:[~2019-05-08 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 11:37 [PATCH v2] v4l: Add source event change for bit-depth Stanimir Varbanov
2019-05-08 15:34 ` Stanimir Varbanov
2019-05-08 16:38   ` Hans Verkuil [this message]
2019-05-08 22:14     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a63d1c5f-806e-92c3-a6f7-e70f0686a27d@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).