From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F8FEB64DA for ; Wed, 14 Jun 2023 11:30:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243993AbjFNLa0 convert rfc822-to-8bit (ORCPT ); Wed, 14 Jun 2023 07:30:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234041AbjFNLaY (ORCPT ); Wed, 14 Jun 2023 07:30:24 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7053E55 for ; Wed, 14 Jun 2023 04:30:21 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mtapsc-8-f8v9-c73Obe53UlMQEGF2A-1; Wed, 14 Jun 2023 12:30:18 +0100 X-MC-Unique: f8v9-c73Obe53UlMQEGF2A-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 14 Jun 2023 12:30:15 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Wed, 14 Jun 2023 12:30:15 +0100 From: David Laight To: 'Sven Schnelle' , Steven Rostedt CC: "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] tracing: fix memcpy size when copying stack entries Thread-Topic: [PATCH] tracing: fix memcpy size when copying stack entries Thread-Index: AQHZnqzKx3JbU4cZlkeCRQJzbO4XQa+KKVfQ Date: Wed, 14 Jun 2023 11:30:15 +0000 Message-ID: References: <20230612160748.4082850-1-svens@linux.ibm.com> <20230612123407.5ebcabdf@gandalf.local.home> <20230613113737.1e07c892@gandalf.local.home> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sven Schnelle > Sent: 14 June 2023 11:41 > > Steven Rostedt writes: > > > On Tue, 13 Jun 2023 07:19:14 +0200 > > Sven Schnelle wrote: > > > >> > Yes the above may be special, but your patch breaks it. > >> > >> Indeed, i'm feeling a bit stupid for sending that patch, should have > >> used my brain during reading the source. Thanks for the explanation. > > > > Does this quiet the fortifier? > > [..] > > No, still getting the same warning: > > [ 2.302776] memcpy: detected field-spanning write (size 104) of single field "stack" at > kernel/trace/trace.c:3178 (size 64) What about: (memcpy)(......) Or maybe: (__builtin_memcpy)(....) David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)