From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Gottfried Haider <gottfried.haider@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: <stefan.wahren@i2se.com>, <gohai@sukzessiv.net>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
<loic.pallardy@st.com>, <broonie@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-rpi-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<linux-pwm@vger.kernel.org>, <michal.vokac@ysoft.com>
Subject: Re: [RESEND PATCH] Revert "pwm: Set class for exported channels in sysfs"
Date: Mon, 1 Oct 2018 15:28:37 +0200 [thread overview]
Message-ID: <a6589b2d-c9b3-88a3-f764-e8519db09dbc@st.com> (raw)
In-Reply-To: <CAPoCmY+mNYSV8gq7VCcSJHDpmoq-i7SDJ6uQ5VbLpMZB=b0waQ@mail.gmail.com>
On 09/29/2018 02:19 AM, Gottfried Haider wrote:
> Hello Thierry & Fabrice,
>
>>> Still, it is possible to send uevent (KOBJ_CHANGE) on pwmchipN device,
>>> to notify of a change, e.g. pwmX channel being exported/unexported.
>
> I tested this patch, and I am happy to report that it works with the
> udev rule that Raspbian (Raspberry Pi's Debian derivative) has in
> place:
>
> SUBSYSTEM=="pwm*", PROGRAM="/bin/sh -c '\
> chown -R root:gpio /sys/class/pwm && chmod -R 770 /sys/class/pwm;\
> chown -R root:gpio
> /sys/devices/platform/soc/*.pwm/pwm/pwmchip* && chmod -R 770
> /sys/devices/platform/soc/*.pwm/pwm/pwmchip*\
> '"
>
>
> So while I can't comment on the uevent semantics, it would solve what
> the original patch attempted to enable (non-root use of pwm).
>
> Tested-by: Gottfried Haider <gottfried.haider@gmail.com>
Hi Gottfried, Thierry,
Thanks for testing. I just sent a new series with:
- revert patch
- additional patch with proposed uevent notification (change) on pwmchip.
Best Regards,
Fabrice
>
> Best,
> Gottfried
>
next prev parent reply other threads:[~2018-10-01 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 14:02 [RESEND PATCH] Revert "pwm: Set class for exported channels in sysfs" Fabrice Gasnier
2018-09-24 11:53 ` Thierry Reding
2018-09-24 13:59 ` Fabrice Gasnier
2018-09-24 14:23 ` Thierry Reding
2018-09-24 15:50 ` Fabrice Gasnier
2018-09-25 13:59 ` Fabrice Gasnier
2018-09-25 15:20 ` Thierry Reding
2018-09-29 0:19 ` Gottfried Haider
2018-10-01 13:28 ` Fabrice Gasnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-20 7:27 Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6589b2d-c9b3-88a3-f764-e8519db09dbc@st.com \
--to=fabrice.gasnier@st.com \
--cc=broonie@kernel.org \
--cc=gohai@sukzessiv.net \
--cc=gottfried.haider@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=loic.pallardy@st.com \
--cc=michal.vokac@ysoft.com \
--cc=stefan.wahren@i2se.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).