From: Samuel Zou <zou_wei@huawei.com>
To: Joe Perches <joe@perches.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler
Date: Wed, 29 Apr 2020 11:50:21 +0800 [thread overview]
Message-ID: <a67b8ad8-f157-2200-910d-19b23dcf77ab@huawei.com> (raw)
In-Reply-To: <01d45e599732bc5af33a09b36e63beabfcad8d25.camel@perches.com>
Hi Joe,
Thanks for your comments, I will modify and send the v2
On 2020/4/29 11:23, Joe Perches wrote:
> On Wed, 2020-04-29 at 11:15 +0800, Zou Wei wrote:
>> fix coccinelle warning, use ARRAY_SIZE
>>
>> drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>> ---
>> drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
>> index b24788e..ac12725 100644
>> --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
>> +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
>> @@ -710,8 +710,7 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in,
>> if (!hwdev)
>> return -EFAULT;
>>
>> - cmd_number = sizeof(nic_vf_cmd_msg_handler) /
>> - sizeof(struct vf_cmd_msg_handle);
>> + cmd_number = ARRAY_SIZE(nic_vf_cmd_msg_handler);
>> pfhwdev = container_of(dev, struct hinic_pfhwdev, hwdev);
>> nic_io = &dev->func_to_io;
>> for (i = 0; i < cmd_number; i++) {
>
> Probably better to remove cmd_number altogether
> ---
> drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
> index b24788..af70cc 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
> @@ -704,17 +704,15 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in,
> struct hinic_hwdev *dev = hwdev;
> struct hinic_func_to_io *nic_io;
> struct hinic_pfhwdev *pfhwdev;
> - u32 i, cmd_number;
> + u32 i;
> int err = 0;
>
> if (!hwdev)
> return -EFAULT;
>
> - cmd_number = sizeof(nic_vf_cmd_msg_handler) /
> - sizeof(struct vf_cmd_msg_handle);
> pfhwdev = container_of(dev, struct hinic_pfhwdev, hwdev);
> nic_io = &dev->func_to_io;
> - for (i = 0; i < cmd_number; i++) {
> + for (i = 0; i < ARRAY_SIZE(nic_vf_cmd_msg_handler); i++) {
> vf_msg_handle = &nic_vf_cmd_msg_handler[i];
> if (cmd == vf_msg_handle->cmd &&
> vf_msg_handle->cmd_msg_handler) {
> @@ -725,7 +723,7 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in,
> break;
> }
> }
> - if (i == cmd_number)
> + if (i == ARRAY_SIZE(nic_vf_cmd_msg_handler))
> err = hinic_msg_to_mgmt(&pfhwdev->pf_to_mgmt, HINIC_MOD_L2NIC,
> cmd, buf_in, in_size, buf_out,
> out_size, HINIC_MGMT_MSG_SYNC);
>
>
>
> .
>
prev parent reply other threads:[~2020-04-29 3:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 3:15 [PATCH -next] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler Zou Wei
2020-04-29 3:23 ` Joe Perches
2020-04-29 3:50 ` Samuel Zou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67b8ad8-f157-2200-910d-19b23dcf77ab@huawei.com \
--to=zou_wei@huawei.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).