From: Vladimir Zapolskiy <vz@mleia.com>
To: Arnd Bergmann <arnd@arndb.de>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sylvain Lemieux <slemieux.tyco@gmail.com>
Cc: kernel test robot <lkp@intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udc: lpc32xx: mark local function static
Date: Tue, 30 Jun 2020 21:32:26 +0300 [thread overview]
Message-ID: <a6812131-1b40-a5bf-ede5-07a1ecde57dd@mleia.com> (raw)
In-Reply-To: <20200630115836.1283978-1-arnd@arndb.de>
Hi Arnd, thank you for the patch.
On 6/30/20 2:58 PM, Arnd Bergmann wrote:
> The kernel test robot reports two functions that should be marked
> static:
>
>>> drivers/usb/gadget/udc/lpc32xx_udc.c:1928:6: warning: no previous prototype for 'udc_send_in_zlp' [-Wmissing-prototypes]
> 1928 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
>>> drivers/usb/gadget/udc/lpc32xx_udc.c:1942:6: warning: no previous prototype for 'udc_handle_eps' [-Wmissing-prototypes]
> 1942 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
>
> This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit
> compiler warning") made it possible to build the driver on x86-64.
>
> Fix the warning as suggested.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2020-06-30 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 11:58 [PATCH] udc: lpc32xx: mark local function static Arnd Bergmann
2020-06-30 18:32 ` Vladimir Zapolskiy [this message]
2020-07-06 15:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6812131-1b40-a5bf-ede5-07a1ecde57dd@mleia.com \
--to=vz@mleia.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=slemieux.tyco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).