From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7674AC4CECE for ; Fri, 13 Mar 2020 08:54:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C160206FA for ; Fri, 13 Mar 2020 08:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="cV6cjqSM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726535AbgCMIyV (ORCPT ); Fri, 13 Mar 2020 04:54:21 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:29796 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgCMIyV (ORCPT ); Fri, 13 Mar 2020 04:54:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584089660; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=EdOQDHBg39WgM6SHH2cUpVxzdMsjPDz8V0RpskWpOiE=; b=cV6cjqSMKHIzLc7bPMEWHmFZR1Rbet5kcrtlh4xNgS/k8EkVrc+OSmBO0MmPZHvsFQyt9Ako eEE/veDwfLqNFF5hL3UllUT8hS5FVbG70tPDi5oOIWwOhEXYvOfQ/2iibpjka/hLjS4rsOz2 bvr+RzPg96KH7ch8uDJk6u90hWM= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e6b4a29.7fb93bad4ae8-smtp-out-n02; Fri, 13 Mar 2020 08:54:01 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 18B90C43636; Fri, 13 Mar 2020 08:54:01 +0000 (UTC) Received: from [10.206.13.37] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mkshah) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1EF4BC433CB; Fri, 13 Mar 2020 08:53:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1EF4BC433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=mkshah@codeaurora.org Subject: Re: [PATCH v13 2/5] soc: qcom: rpmh: Update dirty flag only when data changes To: Doug Anderson Cc: Stephen Boyd , Matthias Kaehlcke , Evan Green , Bjorn Andersson , LKML , linux-arm-msm , Andy Gross , Rajendra Nayak , Lina Iyer , lsrao@codeaurora.org References: <1583746236-13325-1-git-send-email-mkshah@codeaurora.org> <1583746236-13325-3-git-send-email-mkshah@codeaurora.org> From: Maulik Shah Message-ID: Date: Fri, 13 Mar 2020 14:23:54 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 3/10/2020 5:12 AM, Doug Anderson wrote: > Hi, > > On Mon, Mar 9, 2020 at 2:31 AM Maulik Shah wrote: >> Currently rpmh ctrlr dirty flag is set for all cases regardless of data >> is really changed or not. Add changes to update dirty flag when data is >> changed to newer values. Update dirty flag everytime when data in batch >> cache is updated since rpmh_flush() may get invoked from any CPU instead >> of only last CPU going to low power mode. >> >> Also move dirty flag updates to happen from within cache_lock and remove >> unnecessary INIT_LIST_HEAD() call and a default case from switch. >> >> Fixes: 600513dfeef3 ("drivers: qcom: rpmh: cache sleep/wake state requests") >> Signed-off-by: Maulik Shah >> Reviewed-by: Srinivas Rao L >> Reviewed-by: Evan Green >> --- >> drivers/soc/qcom/rpmh.c | 19 +++++++++++-------- >> 1 file changed, 11 insertions(+), 8 deletions(-) > Reviewed-by: Douglas Anderson Thanks for the review doug. Hi bjorn, can you please pull in first 2 changes in the series. while the others are still under discussion, pulling in these first 2 will help avoid send them each time. Thanks, Maulik -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation