* [PATCH] mtd: rawnand: stm32_fmc2: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 7:42 Cai Huoqing
2021-09-01 15:58 ` [Linux-stm32] " Christophe Kerello
2021-09-14 17:39 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-01 7:42 UTC (permalink / raw)
To: caihuoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, linux-mtd, linux-stm32,
linux-arm-kernel, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
index 1c277fbb91f2..97b4e02e43e4 100644
--- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
@@ -1899,15 +1899,11 @@ static int stm32_fmc2_nfc_probe(struct platform_device *pdev)
nfc->data_phys_addr[chip_cs] = res->start;
- res = platform_get_resource(pdev, IORESOURCE_MEM,
- mem_region + 1);
- nfc->cmd_base[chip_cs] = devm_ioremap_resource(dev, res);
+ nfc->cmd_base[chip_cs] = devm_platform_ioremap_resource(pdev, mem_region + 1);
if (IS_ERR(nfc->cmd_base[chip_cs]))
return PTR_ERR(nfc->cmd_base[chip_cs]);
- res = platform_get_resource(pdev, IORESOURCE_MEM,
- mem_region + 2);
- nfc->addr_base[chip_cs] = devm_ioremap_resource(dev, res);
+ nfc->addr_base[chip_cs] = devm_platform_ioremap_resource(pdev, mem_region + 2);
if (IS_ERR(nfc->addr_base[chip_cs]))
return PTR_ERR(nfc->addr_base[chip_cs]);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Linux-stm32] [PATCH] mtd: rawnand: stm32_fmc2: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 7:42 [PATCH] mtd: rawnand: stm32_fmc2: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-01 15:58 ` Christophe Kerello
2021-09-14 17:39 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Kerello @ 2021-09-01 15:58 UTC (permalink / raw)
To: Cai Huoqing
Cc: Vignesh Raghavendra, Richard Weinberger, Alexandre Torgue,
linux-kernel, linux-mtd, Maxime Coquelin, Miquel Raynal,
linux-stm32, linux-arm-kernel
On 9/1/21 9:42 AM, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> index 1c277fbb91f2..97b4e02e43e4 100644
> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> @@ -1899,15 +1899,11 @@ static int stm32_fmc2_nfc_probe(struct platform_device *pdev)
>
> nfc->data_phys_addr[chip_cs] = res->start;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM,
> - mem_region + 1);
> - nfc->cmd_base[chip_cs] = devm_ioremap_resource(dev, res);
> + nfc->cmd_base[chip_cs] = devm_platform_ioremap_resource(pdev, mem_region + 1);
> if (IS_ERR(nfc->cmd_base[chip_cs]))
> return PTR_ERR(nfc->cmd_base[chip_cs]);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM,
> - mem_region + 2);
> - nfc->addr_base[chip_cs] = devm_ioremap_resource(dev, res);
> + nfc->addr_base[chip_cs] = devm_platform_ioremap_resource(pdev, mem_region + 2);
> if (IS_ERR(nfc->addr_base[chip_cs]))
> return PTR_ERR(nfc->addr_base[chip_cs]);
> }
>
Reviewed-by: Christophe Kerello <christophe.kerello@foss.st.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: rawnand: stm32_fmc2: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 7:42 [PATCH] mtd: rawnand: stm32_fmc2: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 15:58 ` [Linux-stm32] " Christophe Kerello
@ 2021-09-14 17:39 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2021-09-14 17:39 UTC (permalink / raw)
To: Cai Huoqing
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue, linux-mtd, linux-stm32,
linux-arm-kernel, linux-kernel
On Wed, 2021-09-01 at 07:42:22 UTC, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> Reviewed-by: Christophe Kerello <christophe.kerello@foss.st.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-14 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 7:42 [PATCH] mtd: rawnand: stm32_fmc2: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 15:58 ` [Linux-stm32] " Christophe Kerello
2021-09-14 17:39 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).