From: Paolo Bonzini <pbonzini@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>, tglx@linutronix.de
Cc: bigeasy@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
torvalds@linux-foundation.org, will@kernel.org,
joel@joelfernandes.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Paul Mackerras <paulus@ozlabs.org>,
kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait
Date: Wed, 25 Mar 2020 18:09:52 +0100 [thread overview]
Message-ID: <a6b23828-aa50-bea0-1d2d-03e2871239d4@redhat.com> (raw)
In-Reply-To: <20200324044453.15733-4-dave@stgolabs.net>
On 24/03/20 05:44, Davidlohr Bueso wrote:
> diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
> index 71244bf87c3a..e049fcb3dffb 100644
> --- a/arch/mips/kvm/mips.c
> +++ b/arch/mips/kvm/mips.c
> @@ -290,8 +290,7 @@ static enum hrtimer_restart kvm_mips_comparecount_wakeup(struct hrtimer *timer)
> kvm_mips_callbacks->queue_timer_int(vcpu);
>
> vcpu->arch.wait = 0;
> - if (swq_has_sleeper(&vcpu->wq))
> - swake_up_one(&vcpu->wq);
> + rcuwait_wake_up(&vcpu->wait)
This is missing a semicolon. (KVM MIPS is known not to compile and will
be changed to "depends on BROKEN" in 5.7).
Paolo
> return kvm_mips_count_timeout(vcpu);
next prev parent reply other threads:[~2020-03-25 17:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 4:44 [PATCH -tip 0/4] kvm: Use rcuwait for vcpu blocking Davidlohr Bueso
2020-03-24 4:44 ` [PATCH 1/4] rcuwait: Fix stale wake call name in comment Davidlohr Bueso
2020-03-24 4:44 ` [PATCH 2/4] rcuwait: Let rcuwait_wake_up() return whether or not a task was awoken Davidlohr Bueso
2020-03-24 4:44 ` [PATCH 3/4] kvm: Replace vcpu->swait with rcuwait Davidlohr Bueso
2020-03-24 12:07 ` kbuild test robot
2020-03-24 16:47 ` kbuild test robot
2020-03-24 17:56 ` Davidlohr Bueso
2020-03-25 17:09 ` Paolo Bonzini [this message]
2020-04-14 21:12 ` Davidlohr Bueso
2020-04-15 12:11 ` Paolo Bonzini
2020-04-20 16:41 ` [PATCH v2] " Davidlohr Bueso
2020-04-20 17:12 ` Marc Zyngier
2020-04-20 17:25 ` Paolo Bonzini
2020-04-20 20:56 ` Davidlohr Bueso
2020-04-20 21:04 ` Paolo Bonzini
2020-04-20 21:50 ` Davidlohr Bueso
2020-04-21 9:43 ` Paolo Bonzini
2020-04-21 18:07 ` Davidlohr Bueso
2020-04-21 19:52 ` Paolo Bonzini
2020-03-24 4:44 ` [PATCH 4/4] sched/swait: Reword some of the main description Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b23828-aa50-bea0-1d2d-03e2871239d4@redhat.com \
--to=pbonzini@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=joel@joelfernandes.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulus@ozlabs.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).