From: Andy Lutomirski <luto@amacapital.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Josh Triplett <josh@joshtriplett.org>,
Rob Landley <rob@landley.net>,
Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org,
Chuck Ebbert <cebbert.lkml@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Shuah Khan <shuah.kh@samsung.com>,
Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH] init: Remove CONFIG_INIT_FALLBACK
Date: Mon, 20 Oct 2014 15:04:36 -0700 [thread overview]
Message-ID: <a6b3d86db6f5d19f7130b8dba2703dda68cb14d5.1413842560.git.luto@amacapital.net> (raw)
In-Reply-To: <20141020144448.59e2e067d632c70353296e56@linux-foundation.org>
CONFIG_INIT_FALLBACK adds config bloat without an obvious use case
that makes it worth keeping around. Delete it.
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
Bring on the blame :)
init/Kconfig | 16 ----------------
init/main.c | 5 -----
2 files changed, 21 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index ebbd5846478e..e84c6423a2e5 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1299,22 +1299,6 @@ source "usr/Kconfig"
endif
-config INIT_FALLBACK
- bool "Fall back to defaults if init= parameter is bad"
- default y
- help
- If enabled, the kernel will try the default init binaries if an
- explicit request from the init= parameter fails.
-
- This can have unexpected effects. For example, booting
- with init=/sbin/kiosk_app will run /sbin/init or even /bin/sh
- if /sbin/kiosk_app cannot be executed.
-
- The default value of Y is consistent with historical behavior.
- Selecting N is likely to be more appropriate for most uses,
- especially on kiosks and on kernels that are indended to be
- run under the control of a script.
-
config CC_OPTIMIZE_FOR_SIZE
bool "Optimize for size"
help
diff --git a/init/main.c b/init/main.c
index 2bd6105e5dc5..39dd52a3b78a 100644
--- a/init/main.c
+++ b/init/main.c
@@ -960,13 +960,8 @@ static int __ref kernel_init(void *unused)
ret = run_init_process(execute_command);
if (!ret)
return 0;
-#ifndef CONFIG_INIT_FALLBACK
panic("Requested init %s failed (error %d).",
execute_command, ret);
-#else
- pr_err("Failed to execute %s (error %d). Attempting defaults...\n",
- execute_command, ret);
-#endif
}
if (!try_to_run_init_process("/sbin/init") ||
!try_to_run_init_process("/etc/init") ||
--
1.9.3
next prev parent reply other threads:[~2014-10-20 22:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 2:40 [PATCH v5] init: Disable defaults if init= fails Andy Lutomirski
2014-09-30 12:12 ` Chuck Ebbert
2014-10-01 0:41 ` Frank Rowand
2014-10-01 0:58 ` Rob Landley
2014-10-01 1:52 ` Frank Rowand
2014-10-01 3:16 ` Rob Landley
2014-10-01 4:53 ` Andy Lutomirski
2014-10-01 18:05 ` josh
2014-10-01 18:13 ` Andy Lutomirski
2014-10-01 22:42 ` josh
2014-10-14 21:00 ` Andrew Morton
2014-10-14 21:21 ` Andy Lutomirski
2014-10-15 5:46 ` Frank Rowand
2014-10-15 5:56 ` Andy Lutomirski
2014-10-15 6:37 ` Frank Rowand
2014-10-15 15:18 ` Rob Landley
2014-10-20 20:14 ` Andy Lutomirski
2014-10-20 21:01 ` Josh Triplett
2014-10-20 21:28 ` Andrew Morton
2014-10-20 21:34 ` Andy Lutomirski
2014-10-20 21:41 ` Andrew Morton
2014-10-20 21:42 ` Andy Lutomirski
2014-10-20 21:44 ` Andrew Morton
2014-10-20 22:04 ` Andy Lutomirski [this message]
2014-10-20 22:06 ` [PATCH] init: Remove CONFIG_INIT_FALLBACK josh
2014-10-21 3:45 ` Rob Landley
2014-10-21 4:02 ` Andy Lutomirski
2014-10-21 4:15 ` Rob Landley
2014-10-21 9:53 ` Geert Uytterhoeven
2014-10-21 10:05 ` Josh Triplett
2014-10-14 0:47 ` [PATCH v5] init: Disable defaults if init= fails Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b3d86db6f5d19f7130b8dba2703dda68cb14d5.1413842560.git.luto@amacapital.net \
--to=luto@amacapital.net \
--cc=akpm@linux-foundation.org \
--cc=cebbert.lkml@gmail.com \
--cc=frowand.list@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
--cc=shuah.kh@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).