From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C89C43467 for ; Thu, 8 Oct 2020 12:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F7262184D for ; Thu, 8 Oct 2020 12:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730177AbgJHM4P (ORCPT ); Thu, 8 Oct 2020 08:56:15 -0400 Received: from mx2.suse.de ([195.135.220.15]:53718 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729722AbgJHM4O (ORCPT ); Thu, 8 Oct 2020 08:56:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CB678B00A; Thu, 8 Oct 2020 12:56:13 +0000 (UTC) Subject: Re: [PATCH v2 3/7] mm, page_alloc: remove setup_pageset() To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim References: <20201008114201.18824-1-vbabka@suse.cz> <20201008114201.18824-4-vbabka@suse.cz> <20201008122309.GB4967@dhcp22.suse.cz> From: Vlastimil Babka Message-ID: Date: Thu, 8 Oct 2020 14:56:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201008122309.GB4967@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/8/20 2:23 PM, Michal Hocko wrote: > On Thu 08-10-20 13:41:57, Vlastimil Babka wrote: >> We initialize boot-time pagesets with setup_pageset(), which sets high and >> batch values that effectively disable pcplists. >> >> We can remove this wrapper if we just set these values for all pagesets in >> pageset_init(). Non-boot pagesets then subsequently update them to the proper >> values. >> >> No functional change. >> >> Signed-off-by: Vlastimil Babka >> Reviewed-by: David Hildenbrand > > Acked-by: Michal Hocko Thanks! > Btw. where do we initialize pcp->count? I thought that pcp allocator > zeroes out the allocated memory but alloc_percpu is GFP_KERNEL like. pageset_init() does: memset(p, 0, sizeof(*p))