From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751705AbdA3DHk (ORCPT ); Sun, 29 Jan 2017 22:07:40 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:34434 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750968AbdA3DHb (ORCPT ); Sun, 29 Jan 2017 22:07:31 -0500 Subject: Re: linux-next: build failure after merge of the block tree To: Stephen Rothwell References: <20170130124350.36a57549@canb.auug.org.au> <5f2da80f-c6fe-8c45-0e56-819aae7d925c@kernel.dk> Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig From: Jens Axboe Message-ID: Date: Sun, 29 Jan 2017 20:07:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <5f2da80f-c6fe-8c45-0e56-819aae7d925c@kernel.dk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2017 06:53 PM, Jens Axboe wrote: > On 01/29/2017 06:43 PM, Stephen Rothwell wrote: >> Hi Jens, >> >> After merging the block tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> drivers/nvme/host/scsi.c: In function 'nvme_scsi_translate': >> drivers/nvme/host/scsi.c:2350:9: error: 'BLK_MAX_CDB' undeclared (first use in this function) >> u8 cmd[BLK_MAX_CDB]; >> ^ >> drivers/nvme/host/scsi.c:2350:9: note: each undeclared identifier is reported only once for each function it appears in >> drivers/nvme/host/scsi.c:2350:5: warning: unused variable 'cmd' [-Wunused-variable] >> u8 cmd[BLK_MAX_CDB]; >> ^ >> drivers/nvme/host/scsi.c: In function 'nvme_sg_io': >> drivers/nvme/host/scsi.c:2454:20: error: 'BLK_MAX_CDB' undeclared (first use in this function) >> if (hdr.cmd_len > BLK_MAX_CDB) >> ^ >> >> Caused by commit >> >> 82ed4db499b8 ("block: split scsi_request out of struct request") >> >> I have used the block tree from next-20170125 for today. > > Huh, I wonder how that snuck past my allmodconfig builds, that looks > like a clear failure. Fixed, sorry about that. -- Jens Axboe