From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Joe Perches <joe@perches.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>, wsa@kernel.org
Subject: Re: [PATCH v2 1/3] units: Add SI metric prefix definitions
Date: Tue, 8 Jun 2021 11:42:46 +0300 [thread overview]
Message-ID: <a6f0677c-70b0-2a51-a01b-f84bcacfc0bd@linux.intel.com> (raw)
In-Reply-To: <ae919bae6c21e23b0a1ed0c9327738e59dd90aa0.camel@perches.com>
On 6/7/21 10:09 PM, Joe Perches wrote:
> On Mon, 2021-06-07 at 18:23 +0300, Andy Shevchenko wrote:
>> +#define HECTO 100L
>> +#define DECA 10L
>
> Should it be DECA or DEKA or both?
>
> https://www.nist.gov/pml/weights-and-measures/metric-si-prefixes
> deka Example: dekameter da 10**1 Ten
>
>> +#define DECI 10L
>> +#define CENTI 100L
>> +#define MILLI 1000L
>> +#define MICRO 1000000L
>> +#define NANO 1000000000L
>> +#define PICO 1000000000000LL
>> +#define FEMTO 1000000000000000LL
>
> IMO: Might as well include all the prefixes up to 10**24
>
> EXA ZETTA YOTTA, ATTA ZEPTO YOCTO
>
> And how do people avoid using MILLI for KILO, MEGA for MICRO, etc...
> The compiler won't care but usage could look odd.
> I find this patch creates more confusion than solves a real problem
(typo where one zero is missing or one extra) and adds potentially
needless churn. For instance I don't assume much use for the HECTO now
or in the future.
How about if absolutely necessary just adding only KILO, MEGA and GIGA
and questionable defines only after when the real needs arises and can
see does "1/1000L" etc define cause any troubles to real calculations?
Jarkko
next prev parent reply other threads:[~2021-06-08 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 15:23 [PATCH v2 1/3] units: Add SI metric prefix definitions Andy Shevchenko
2021-06-07 15:23 ` [PATCH v2 2/3] i2c: designware: Use DIV_ROUND_CLOSEST() macro Andy Shevchenko
2021-06-07 15:23 ` [PATCH v2 3/3] i2c: designware: Fix indentation in the header Andy Shevchenko
2021-06-07 15:43 ` [PATCH v2 1/3] units: Add SI metric prefix definitions Joe Perches
2021-06-07 15:57 ` Andy Shevchenko
2021-06-07 16:00 ` Joe Perches
2021-06-07 16:55 ` Andy Shevchenko
2021-06-07 19:09 ` Joe Perches
2021-06-08 8:42 ` Jarkko Nikula [this message]
2021-07-12 14:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f0677c-70b0-2a51-a01b-f84bcacfc0bd@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).