From: Alexander Graf <graf@amazon.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>, Ard Biesheuvel <ardb@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>
Subject: Re: [PATCH] ACPI: bus: Match first 9 bytes of device IDs
Date: Fri, 25 Feb 2022 20:06:39 +0100 [thread overview]
Message-ID: <a71a855f-9f3b-c99d-d4f9-c1ceb13c690d@amazon.com> (raw)
In-Reply-To: <CAHmME9rzS5rAKoAfv7+N_R71pWduV=a=gJJoKPoLtYx7m7CFEg@mail.gmail.com>
On 25.02.22 19:39, Jason A. Donenfeld wrote:
> Okay, the final piece, userspace:
>
> /sys/bus/acpi/devices/QEMUVGID:00/modalias gives:
> acpi:QEMUVGID:VM_GEN_COUNTER:
>
> modinfo -F alias vmgenid.ko gives:
> acpi*:VM_GEN_COUNTER:*
>
> udev src uses fnmatch.
>
> Bash confirms a match:
>
> $ [[ "acpi:QEMUVGID:VM_GEN_COUNTER:" == acpi*:VM_GEN_COUNTER:* ]] &&
> echo matches
> matches
>
> So I think with ACPI_ID_LEN --> 16 we are good to go.
Is the size increase (mostly rodata I suppose? Anywhere else?) measurable?
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2022-02-25 19:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 15:55 [PATCH] ACPI: bus: Match first 9 bytes of device IDs Alexander Graf
2022-02-25 16:57 ` Jason A. Donenfeld
2022-02-25 17:09 ` Alexander Graf
2022-02-25 17:16 ` Jason A. Donenfeld
2022-02-25 17:13 ` Ard Biesheuvel
2022-02-25 17:21 ` Jason A. Donenfeld
2022-02-25 17:30 ` Ard Biesheuvel
2022-02-25 17:33 ` Jason A. Donenfeld
2022-02-25 18:03 ` Jason A. Donenfeld
2022-02-25 18:39 ` Jason A. Donenfeld
2022-02-25 19:06 ` Alexander Graf [this message]
2022-02-25 21:03 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a71a855f-9f3b-c99d-d4f9-c1ceb13c690d@amazon.com \
--to=graf@amazon.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).