From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
linux-kernel@vger.kernel.org
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
devicetree@vger.kernel.org,
angelogioacchino.delregno@collabora.corp-partner.google.com,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Subject: Re: [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection
Date: Fri, 28 Oct 2022 13:44:37 +0200 [thread overview]
Message-ID: <a7275ee4-c6ec-c0e8-c49d-dec9ca367d9f@linux.intel.com> (raw)
In-Reply-To: <20221028102450.1161382-3-ajye_huang@compal.corp-partner.google.com>
On 10/28/2022 12:24 PM, Ajye Huang wrote:
> Having two DMICs, a front DMIC and a rear DMIC,
> but only host audio input AUX port0 is used for these two Dmics.
> A "dmic_sel-gpios" property is used for a mixer control to switch
> the dmic signal source between the Front and Rear Dmic.
>
> usage: amixer -c0 cset name='Dmic Mux' 'FrontMic'
> usage: amixer -c0 cset name='Dmic Mux' 'RearMic'
>
> Refer to this one as an example,
> commit 3cfbf07c6d27
> ("ASoC: qcom: sc7180: Modify machine driver for 2mic")
>
> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
> ---
I'm very suspicious of this patchset. As it is you add kcontrol which
won't take effect on most platforms making use of DMIC. It feels to me
that it is something you want to handle on machine driver side instead.
next prev parent reply other threads:[~2022-10-28 11:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:24 [PATCH v1 0/2] Add optional dmic selection for two DMICs Ajye Huang
2022-10-28 10:24 ` [PATCH v1 1/2] ASoC: dt-bindings: Document dmic_sel-gpios optional prop for two DMICs case Ajye Huang
2022-10-28 11:56 ` Mark Brown
2022-10-31 18:43 ` Rob Herring
2022-10-31 20:47 ` Mark Brown
2022-11-01 1:04 ` Ajye Huang
2022-11-01 1:07 ` Ajye Huang
2022-10-28 10:24 ` [PATCH v1 2/2] ASoC: dmic: Add optional dmic selection Ajye Huang
2022-10-28 11:44 ` Amadeusz Sławiński [this message]
2022-10-28 12:54 ` Ajye Huang
2022-10-28 12:58 ` Mark Brown
2022-10-28 11:57 ` Mark Brown
2022-10-28 12:59 ` Ajye Huang
2022-10-28 13:01 ` Mark Brown
2022-10-28 13:09 ` Ajye Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7275ee4-c6ec-c0e8-c49d-dec9ca367d9f@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=ajye_huang@compal.corp-partner.google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.corp-partner.google.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).