From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D09B0C433F5 for ; Mon, 7 Mar 2022 19:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244939AbiCGTE5 (ORCPT ); Mon, 7 Mar 2022 14:04:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237523AbiCGTEy (ORCPT ); Mon, 7 Mar 2022 14:04:54 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 447EA6E56D for ; Mon, 7 Mar 2022 11:03:59 -0800 (PST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 21C6C3F613 for ; Mon, 7 Mar 2022 19:03:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646679838; bh=J4AWHeY6kJDoGGWSDU0TUvtoqIxvWQeYEQ4e5H5diOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hfwauzVEnqFSTqovwMDhWrtwwPu3wIMljO/FaNvTtg0C4ZLbbFFXvolHwx74dAWSg zpFOK+NbWsMKBUptMutpwJhMO5C1O5HOW1nri1zgnHYo/YSwQM1HyW9AruHjSWPIn1 UrSjathh7hGP2APHBb3yYfH44XkGtgQKpkGURlZwqklAJYX2Oea1Dj5roArdYYa6RX BjxKprh1gwhQNBeiCKv2ZRlUeNnTz3AcWXtAZvhMd59mhQaqXLBC9jmvBeqLdpS8RK 0r30OGbmiVEvFV6UHF9nogVjDvZRH6PamoDjSCwdZraU/ncmUOFEzDjEUctdOdreLq /QtJfcVpDBl8Q== Received: by mail-ed1-f71.google.com with SMTP id h17-20020a05640250d100b004133863d836so9199156edb.0 for ; Mon, 07 Mar 2022 11:03:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=J4AWHeY6kJDoGGWSDU0TUvtoqIxvWQeYEQ4e5H5diOY=; b=7S5/aXE8rGDoXQF6l/TmoMKFXKoEpdLYHHZc37aXQO8BDWzbSkE1T3yWYYeh7JhT+7 2ic6sI9cySOm2xbbcf9tWNNnkwgTczYbve/Htu28bHh3b5U7vN0Ykz602JosYIHK3IfO WdyILOt0wszcEFn/+lhWbQYhL8wUaOwGwXpCH8IqrXKV2cKwSWBJiPqznAB7jP2tdcB6 qW+CItPXSadoukRaK5kAfF9JogJN9p+rSmVQAOmAKRsWVBHbpJ9phOn2kecesbo7cYSQ rzL+cFwewe2euMrvNuJm8uhqSDkaQlmLlmo6dm+7Y4nN7JfeV0CTvxIwUw46i4cpTLcQ tu8Q== X-Gm-Message-State: AOAM530YLIn+jTbJ0rRjhCfUUsm1vPfdCjY+w6FtoTIuE7k+2oeimyAZ 4YM80i5+dIrnJrzxlhnxxiBDtR5LD73oizbaDvn5l+39vpa4pbc8upNtlLEqGqRAPGKm6+U9KuX 6cvam9O01BLjiIopcaSF8mIWhxEt2TZa1GfDHMBfpTA== X-Received: by 2002:a50:aa87:0:b0:40f:28a0:d0d6 with SMTP id q7-20020a50aa87000000b0040f28a0d0d6mr12475413edc.368.1646679837656; Mon, 07 Mar 2022 11:03:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKC+brW6i/AxkVvgIwi5JIxVP90rh2B8pfzbYSF4MakKIPVSeOvoB5oYLiqCOs67+OJ+fNaA== X-Received: by 2002:a50:aa87:0:b0:40f:28a0:d0d6 with SMTP id q7-20020a50aa87000000b0040f28a0d0d6mr12475384edc.368.1646679837477; Mon, 07 Mar 2022 11:03:57 -0800 (PST) Received: from [192.168.0.143] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.gmail.com with ESMTPSA id n15-20020a05640206cf00b0041655b577f1sm1268973edy.25.2022.03.07.11.03.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 11:03:56 -0800 (PST) Message-ID: Date: Mon, 7 Mar 2022 20:03:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 4/4] cpufreq: mediatek: add platform data and clean up voltage tracking logic Content-Language: en-US To: Tim Chang , "Rafael J . Wysocki" , Viresh Kumar , Rob Herring , Liam Girdwood , Mark Brown , Matthias Brugger Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, fan.chen@mediatek.com, louis.yu@mediatek.com, roger.lu@mediatek.com, Allen-yy.Lin@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, hsinyi@google.com, Jia-Wei Chang References: <20220307122151.11666-1-jia-wei.chang@mediatek.com> <20220307122151.11666-5-jia-wei.chang@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220307122151.11666-5-jia-wei.chang@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2022 13:21, Tim Chang wrote: > 1. add required header files and remove unnecessary header files. > 2. some soc needs different min/max voltage shift and voltage tracking > attributes. make these variables into platform data to support > future soc. > 3. add need_voltage_tracking variable to platforma data. if true, it > indicates soc is required to realize the voltage tracking between > voltage of sram and voltage of cpu by software approach. otherwise, > the voltage tracking is realized by hardware approach. > 4. add opp frequency look-up function as mtk_cpufreq_get() and > registered in cpufreq framework. > 5. update voltage_tracking() logic and drv_init(). in drv_init(), it > always sets highest opp voltage before return. it could prevent from > high-freqeuncy-low-voltage issue if two or more clients using the > same regulator. One change at a time. > > Signed-off-by: Jia-Wei Chang Your SoB does not match from field. Best regards, Krzysztof