From: Steven Price <steven.price@arm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/panfrost: Reduce the amount of logs on deferred probe
Date: Wed, 25 Sep 2019 10:25:26 +0100 [thread overview]
Message-ID: <a738d0d8-a1a9-5ffb-a858-0c3336339f46@arm.com> (raw)
In-Reply-To: <20190923171222.9256-1-krzk@kernel.org>
On 23/09/2019 18:12, Krzysztof Kozlowski wrote:
> There is no point to print deferred probe (and its failures to get
> resources) as an error. Also there is no need to print regulator errors
> twice.
>
> In case of multiple probe tries this would pollute the dmesg.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Steven Price <steven.price@arm.com>
>
> ---
>
> Changes since v1:
> 1. Remove second error message from calling panfrost_regulator_init().
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 46b0b02e4289..287c6ba314d9 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
> pfdev->regulator = NULL;
> if (ret == -ENODEV)
> return 0;
> - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(pfdev->dev, "failed to get regulator: %d\n",
> + ret);
> return ret;
> }
>
> @@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
> }
>
> err = panfrost_regulator_init(pfdev);
> - if (err) {
> - dev_err(pfdev->dev, "regulator init failed %d\n", err);
> + if (err)
> goto err_out0;
> - }
>
> err = panfrost_reset_init(pfdev);
> if (err) {
>
prev parent reply other threads:[~2019-09-25 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 17:12 [PATCH v2] drm/panfrost: Reduce the amount of logs on deferred probe Krzysztof Kozlowski
2019-09-25 9:25 ` Steven Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a738d0d8-a1a9-5ffb-a858-0c3336339f46@arm.com \
--to=steven.price@arm.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).