From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Rob Herring <robh@kernel.org>
Cc: bauerman@linux.ibm.com, gregkh@linuxfoundation.org,
james.morse@arm.com, catalin.marinas@arm.com, sashal@kernel.org,
will@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, frowand.list@gmail.com,
vincenzo.frascino@arm.com, mark.rutland@arm.com,
dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com,
pasha.tatashin@soleen.com, allison@lohutok.net,
kstewart@linuxfoundation.org, takahiro.akashi@linaro.org,
tglx@linutronix.de, masahiroy@kernel.org, bhsharma@redhat.com,
mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com,
christophe.leroy@c-s.fr, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
prsriva@linux.microsoft.com, balajib@linux.microsoft.com
Subject: Re: [PATCH v9 0/8] Carry forward IMA measurement log on kexec on ARM64
Date: Tue, 01 Dec 2020 06:34:18 -0500 [thread overview]
Message-ID: <a73a47da53b795617758cc23991624dfca173eba.camel@linux.ibm.com> (raw)
In-Reply-To: <415b4d0b-3d93-40ce-b74e-48fdce7fbf7f@linux.microsoft.com>
On Sat, 2020-11-21 at 06:38 -0800, Lakshmi Ramasubramanian wrote:
> On 11/21/20 5:57 AM, Rob Herring wrote:
> > On Fri, Nov 13, 2020 at 11:22:35AM -0800, Lakshmi Ramasubramanian wrote:
> >> arch/powerpc/include/asm/kexec.h | 1 -
> >> arch/powerpc/kexec/Makefile | 7 +-
> >> arch/powerpc/kexec/file_load.c | 32 --------
> >> arch/powerpc/kexec/ima.c | 106 ++-----------------------
> >> drivers/of/Makefile | 9 +++
> >
> >> drivers/of/ima_kexec.c | 91 +++++++++++++++++++++
> >> drivers/of/kexec_fdt.c | 55 +++++++++++++
> >
> > Does this need to be 2 files? Just kexec.c?
>
> Since the functions defined in "ima_kexec.c" and "kexec_fdt.c" are
> enabled on 2 different kernel CONFIGs, keeping them in 2 files enables
> us to avoid using "#ifdef" in C files.
Normally that is true, but just as all of the kexec related functions
are co-located in ima/ima_kexec.c, co-locating all of the kexec related
functions in drivers/of makes sense.
thanks,
Mimi
next prev parent reply other threads:[~2020-12-01 11:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 19:22 [PATCH v9 0/8] Carry forward IMA measurement log on kexec on ARM64 Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 1/8] powerpc: fix compiler warnings and errors Lakshmi Ramasubramanian
2020-12-01 3:16 ` Mimi Zohar
2020-11-13 19:22 ` [PATCH v9 2/8] powerpc: Move delete_fdt_mem_rsv() to drivers/of Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 3/8] ima: Define get_ima_kexec_buffer() in drivers/of Lakshmi Ramasubramanian
2020-12-01 11:37 ` Mimi Zohar
2020-12-01 19:01 ` Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 4/8] powerpc: Use get_ima_kexec_buffer to get ima kexec buffer Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 5/8] powerpc: Move remove_ima_buffer() to drivers/of Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 6/8] powerpc: Move ima_get_kexec_buffer() and ima_free_kexec_buffer() to ima Lakshmi Ramasubramanian
2020-12-01 11:38 ` Mimi Zohar
2020-12-01 19:05 ` Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 7/8] arm64: Store IMA log information in kimage used for kexec Lakshmi Ramasubramanian
2020-12-01 11:39 ` Mimi Zohar
2020-12-01 19:08 ` Lakshmi Ramasubramanian
2020-11-13 19:22 ` [PATCH v9 8/8] arm64: Add IMA kexec buffer to DTB Lakshmi Ramasubramanian
2020-11-21 13:57 ` [PATCH v9 0/8] Carry forward IMA measurement log on kexec on ARM64 Rob Herring
2020-11-21 14:38 ` Lakshmi Ramasubramanian
2020-11-21 19:47 ` Lakshmi Ramasubramanian
2020-12-01 11:34 ` Mimi Zohar [this message]
2020-12-01 19:10 ` Lakshmi Ramasubramanian
2020-12-01 19:15 ` Mimi Zohar
2020-12-02 2:25 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a73a47da53b795617758cc23991624dfca173eba.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=allison@lohutok.net \
--cc=balajib@linux.microsoft.com \
--cc=bauerman@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@c-s.fr \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsinyi@chromium.org \
--cc=james.morse@arm.com \
--cc=jmorris@namei.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mbrugger@suse.com \
--cc=mpe@ellerman.id.au \
--cc=nramas@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=paulus@samba.org \
--cc=prsriva@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=serge@hallyn.com \
--cc=takahiro.akashi@linaro.org \
--cc=tao.li@vivo.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).