From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D516AC433E2 for ; Wed, 9 Sep 2020 01:15:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98B902075A for ; Wed, 9 Sep 2020 01:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599614141; bh=aoPPqYkigbMg79C03RrcJPO1nSUB2QS1fEAEvvm8/eo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=BSeWpy9Y1aG8NVzjeEAsdHkoEjdTN/synwvmkVquZYpZ8uAPEPMN24urkWlziBDzD cgvVebldN1coBxkyLsGANX/LviEKZoCSVCE2j6pjbYPdg1GCmr2m9yOZZ7Dv7oV49j tjGlCHkf3xo83M3qMGS7PD6GmSJtXUpIDtZv1dt4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbgIIBPk (ORCPT ); Tue, 8 Sep 2020 21:15:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbgIIBPk (ORCPT ); Tue, 8 Sep 2020 21:15:40 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79D27C061573 for ; Tue, 8 Sep 2020 18:15:25 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id j2so1418061ioj.7 for ; Tue, 08 Sep 2020 18:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MIYTcp/Op5a10KklY/9ieZKoD7aXDcPKvRlgBCiIESA=; b=EF5YLArF/ZZbYoNcsVGDMKeApLvzBwIidiprPDtO4wMqS4GKYVy9dr3Cuv3OEuMvge 1VLfjlj6S9pZZ48ioAhUxcdnt74utdncO/zYjUhAOt7v8mLUgzewYMGZa/V9YJ/rJEZp TdWKayXHXEokzzVc3d9T/07lJxfWKs/8MlzUQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MIYTcp/Op5a10KklY/9ieZKoD7aXDcPKvRlgBCiIESA=; b=Hnfz5mABKCt0ZGk1XsZ0fZwLVtZ5LKKvq1Pef5AOjHGKOXnSJoYDmbX9/luGY4TtDU CMTaJCugnFDULrIVREG3N1+0HwkiN8q3u0Gvfx1Xva8OVmrlneQ4VV8hGoRD5CbTQ8RT 7IkLoun1OH9E9vVn3Had1Ire6ad1X6R8FUpkOjdjxDqAhdXne6Q1lM96UXqKMTtO897g 50ZQ6hjE2X1rNIeUejYzhbxk2Y00TUXWOvoZOdYx/5TDd0n/zVXFRuoNoIxudZ1oMER3 GQZUrD5Pws5IU0JvuFC/i7Zi2VBt+l7eIDnVQZVtNMFJrOaT3iAPHu2k51n+KFk+iuuu nJ8Q== X-Gm-Message-State: AOAM531IpOopW7EjJSwILAM8UO+8S48x+HhTANDFhLKnZgE70fJ+9UTf dyxV5LBofGikeR4rHRD7GJwrSQ== X-Google-Smtp-Source: ABdhPJzETaQNxPwlIydTejqSxt3WugkEgQ/tyv6cfpBtiz2lS9sBnVWygePdpPQKtmfM7lkIrgmNEg== X-Received: by 2002:a05:6602:2c07:: with SMTP id w7mr1509605iov.53.1599614124651; Tue, 08 Sep 2020 18:15:24 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i1sm460613ilk.39.2020.09.08.18.15.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 18:15:24 -0700 (PDT) Subject: Re: [PATCH v6 00/20] gpio: cdev: add uAPI v2 To: Kent Gibson Cc: Bartosz Golaszewski , Bamvor Jian Zhang , Shuah Khan , LKML , linux-gpio , Linus Walleij , Shuah Khan References: <20200831032006.1019978-1-warthog618@gmail.com> <20200903083750.GA17445@sol> <20200904125250.GA323947@sol> <9db62b42-9a1e-0264-e88c-e636004cb629@linuxfoundation.org> <20200909010900.GA8496@sol> From: Shuah Khan Message-ID: Date: Tue, 8 Sep 2020 19:15:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200909010900.GA8496@sol> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/8/20 7:09 PM, Kent Gibson wrote: > On Tue, Sep 08, 2020 at 10:04:05AM -0600, Shuah Khan wrote: >> On 9/8/20 9:54 AM, Bartosz Golaszewski wrote: >>> On Tue, Sep 8, 2020 at 5:24 PM Shuah Khan wrote: >>>> >>>> On 9/4/20 7:02 AM, Bartosz Golaszewski wrote: >>>>> On Fri, Sep 4, 2020 at 2:52 PM Kent Gibson wrote: >>>>>> >>>>>> On Thu, Sep 03, 2020 at 04:37:50PM +0800, Kent Gibson wrote: >>>>>>> On Thu, Sep 03, 2020 at 10:02:04AM +0200, Bartosz Golaszewski wrote: >>>>>>>> On Mon, Aug 31, 2020 at 5:21 AM Kent Gibson wrote: >>>>>>>>> >>>>>> [snip] >>>>>>>> >>>>>>>> To me it looks good, just a couple nits here and there and some questions. >>>>>>>> >>>>>>>> I think it's worth deciding whether we want to keep the selftests in >>>>>>>> tools/testing/selftests/gpio/ and then maybe consider porting >>>>>>>> gpio-mockup-chardev.c to V2 or simply outsource it entirely to >>>>>>>> libgpiod. >>>>>>>> >>>>>>> >>>>>>> Ooops - I wasn't even aware they existed - though it had crossed my mind >>>>>>> that the kernel should have some selftests somewhere - I use the libgpiod >>>>>>> tests, from my libgpiod port, and my own Go based test suite for my testing, >>>>>>> as well as some smoke tests with the tools/gpio. >>>>>>> >>>>>>> The libgpiod tests only cover v1 equivalent functionality, while my Go >>>>>>> tests cover the complete uAPI, and both v1 and v2. >>>>>>> >>>>>>> It would be good for the kernel to at least have some smoke tests to >>>>>>> confirm basic functionality, even thorough testing is left to a >>>>>>> userspace library. So the existing tests should be ported to v2, though >>>>>>> should also retain the v1 tests if v1 is still compiled in. >>>>>>> >>>>>> >>>>>> I've got a v7 ready to submit that includes a couple of patches for the >>>>>> gpio-mockup selftests (their primary purpose appears to be testing the >>>>>> mockup module, rather than the GPIO ABI), but I now notice that the >>>>>> selftests/gpio section of the tree has a different maintainer: >>>>>> >>>>>> scripts/get_maintainer.pl 0021-selftests-gpio-port-to-GPIO-uAPI-v2.patch >>>>>> Bamvor Jian Zhang (maintainer:GPIO MOCKUP DRIVER) >>>>>> Shuah Khan (maintainer:KERNEL SELFTEST FRAMEWORK) >>>>>> linux-gpio@vger.kernel.org (open list:GPIO MOCKUP DRIVER) >>>>>> linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK) >>>>>> linux-kernel@vger.kernel.org (open list) >>>>> >>>>> Bamvor, Shuah: do you still have interest in maintaining these, or can >>>>> we update MAINTAINERS? >>>>> >>>> >>>> I maintain kselftests and gpio selftest falls under that. Please send >>>> selftest patches to me so I can review them. >>>> >>>> As for the gpio mock driver and test itself, you will have to wait for >>>> Bamvor to respond. >>>> >>> >>> Hi Shuah, >>> >>> I've been de facto maintaining gpio-mockup for a couple years now. >>> Bamvor has been quite inactive as far as gpio testing goes. I think >>> it's fine if you ack the selftests changes. >>> >> >> That is fine. I can do quick review and Ack so you can take them >> through gpio tree. >> >>> In fact: I don't want selftests to block getting V2 uAPI upstream so >>> if that'll look like it's going to take more time then I'm for merging >>> V2 without any changes to selftests - in the end we have tests in >>> user-space already. >>> >> >> Tests and features go through subsystem trees to avoid delays. Please >> make sure the test doesn't break the default kselftest build/run. >> >> In the future it would help if you include all the maintainers on the >> patch series, so I can review the tests from the framework angle to >> see if they build/run correctly. >> > > To clarify, the patches have been submitted to the correct maintainers. > While this v6, and those before, inadvertently broke the gpio selftests > by removing code they depend on, there have been no code changes in the > selftest tree, and so nothing for you to review. The v7 of this series > restored the functions that the selftests use so that they again build > and run - still nothing for you to review. > > While I had patches for the selftests available for v7, I pulled them > from the patch series as I didn't want to bother you or Bamvor with the > other patches that you wouldn't be interested in. Further, the gpio > selftests are intended to test the gpio-mockup, as evidenced by Bamvor > being their maintainer and the code itself. There have been no changes > to the mockup here, and the existing selftests remain valid without being > ported to the latest GPIO uAPI. Porting them to the latest uAPI, and then > removing the resulting dead code from tools/gpio, is a nice to have that > can wait and shouldn't block getting the uAPI changes in tree. > Thanks for the clarification. -- Shuah