From: Jammy Huang <jammy_huang@aspeedtech.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Eddie James <eajames@linux.ibm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: aspeed: Fix no complete irq for non-64-aligned width
Date: Wed, 12 Jan 2022 14:05:41 +0800 [thread overview]
Message-ID: <a779f1c1-e5b0-5d55-bc6c-5f253d03525d@aspeedtech.com> (raw)
In-Reply-To: <CACPK8XfkXi6M=gzfkYcuoga6WxnzSm2+mspBt4gjop7Ytm+VCA@mail.gmail.com>
Hi Joel,
OK, thanks for your review. I will send another updated patch per your
advice.
On 2022/1/12 上午 08:51, Joel Stanley wrote:
> On Tue, 14 Dec 2021 at 04:53, Jammy Huang <jammy_huang@aspeedtech.com> wrote:
>> In ast2500, engine will stop occasionally for 1360x768.
>>
>> This is a bug which has been addressed, but the workaround is specific
>> for 1680 only. Here we make it more complete.
>>
>> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
>> ---
>> drivers/media/platform/aspeed-video.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
>> index 793b2adaa0f5..4d3e6b105d44 100644
>> --- a/drivers/media/platform/aspeed-video.c
>> +++ b/drivers/media/platform/aspeed-video.c
>> @@ -1055,18 +1055,20 @@ static void aspeed_video_set_resolution(struct aspeed_video *video)
>> /* Set capture/compression frame sizes */
>> aspeed_video_calc_compressed_size(video, size);
>>
>> - if (video->active_timings.width == 1680) {
>> + if (!IS_ALIGNED(act->width, 64)) {
>> /*
>> * This is a workaround to fix a silicon bug on A1 and A2
> Please add: "a AST2500 silicon bug" so we know which A1/A2 this is
> referring to.
>
> With that added, you can add:
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
>> * revisions. Since it doesn't break capturing operation of
>> * other revisions, use it for all revisions without checking
>> - * the revision ID. It picked 1728 which is a very next
>> - * 64-pixels aligned value to 1680 to minimize memory bandwidth
>> + * the revision ID. It picked new width which is a very next
>> + * 64-pixels aligned value to minimize memory bandwidth
>> * and to get better access speed from video engine.
>> */
>> + u32 width = ALIGN(act->width, 64);
>> +
>> aspeed_video_write(video, VE_CAP_WINDOW,
>> - 1728 << 16 | act->height);
>> - size += (1728 - 1680) * video->active_timings.height;
>> + width << 16 | act->height);
>> + size = width * act->height;
> You could make it clearer by putting the write on one line:
>
> aspeed_video_write(video, VE_CAP_WINDOW, width << 16 |
> act->height);
--
Best Regards
Jammy
prev parent reply other threads:[~2022-01-12 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 4:53 [PATCH] media: aspeed: Fix no complete irq for non-64-aligned width Jammy Huang
2022-01-12 0:51 ` Joel Stanley
2022-01-12 6:05 ` Jammy Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a779f1c1-e5b0-5d55-bc6c-5f253d03525d@aspeedtech.com \
--to=jammy_huang@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).