From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Markus Mayer" <mmayer@broadcom.com>,
"Sumeet Pawnikar" <sumeet.r.pawnikar@intel.com>,
"Alejandro González" <alejandro.gonzalez.correo@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Markus Mayer" <markus.mayer@broadcom.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH RESEND] tools/thermal: tmon: include pthread and time headers in tmon.h
Date: Tue, 19 Jul 2022 09:11:29 -0700 [thread overview]
Message-ID: <a78473a8-d4f9-d525-104d-2d08f92a1873@gmail.com> (raw)
In-Reply-To: <20220718031040.44714-1-f.fainelli@gmail.com>
On 7/17/2022 8:10 PM, Florian Fainelli wrote:
> From: Markus Mayer <mmayer@broadcom.com>
>
> Include sys/time.h and pthread.h in tmon.h, so that types
> "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> references them.
>
> Without these headers, compiling tmon against musl-libc will fail with
> these errors:
>
> In file included from sysfs.c:31:0:
> tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
> extern pthread_mutex_t input_lock;
> ^~~~~~~~~~~~~~~
> make[3]: *** [<builtin>: sysfs.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> In file included from tui.c:31:0:
> tmon.h:54:17: error: field 'tv' has incomplete type
> struct timeval tv;
> ^~
> make[3]: *** [<builtin>: tui.o] Error 1
> make[2]: *** [Makefile:83: tmon] Error 2
>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> Acked-by: Alejandro González <alejandro.gonzalez.correo@gmail.com>
> Tested-by: Alejandro González <alejandro.gonzalez.correo@gmail.com>
> ---
> This patch was first submitted here:
>
> https://lore.kernel.org/all/20200617235809.6817-1-mmayer@broadcom.com/
>
> but never applied, meanwhile the issue is still present
Daniel, Rafael, any chance to get that into v5.19-rc7? I should probably
also have added:
Fixes: 94f69966faf8 ("tools/thermal: Introduce tmon, a tool for thermal
subsystem")
Thanks!
--
Florian
next prev parent reply other threads:[~2022-07-19 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 3:10 [PATCH RESEND] tools/thermal: tmon: include pthread and time headers in tmon.h Florian Fainelli
2022-07-19 16:11 ` Florian Fainelli [this message]
2022-07-19 17:06 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78473a8-d4f9-d525-104d-2d08f92a1873@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alejandro.gonzalez.correo@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markus.mayer@broadcom.com \
--cc=mmayer@broadcom.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sumeet.r.pawnikar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).