From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A68C4332F for ; Fri, 15 Oct 2021 16:42:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C73960C51 for ; Fri, 15 Oct 2021 16:42:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241513AbhJOQoS convert rfc822-to-8bit (ORCPT ); Fri, 15 Oct 2021 12:44:18 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:50139 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232499AbhJOQoR (ORCPT ); Fri, 15 Oct 2021 12:44:17 -0400 Received: from [77.244.183.192] (port=62378 helo=[192.168.178.41]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mbQHY-0057QX-Fl; Fri, 15 Oct 2021 18:42:08 +0200 Subject: Re: [PATCH 7/8] watchdog: max77714: add driver for the watchdog in the MAX77714 PMIC To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Lee Jones , Rob Herring , Alessandro Zummo , Alexandre Belloni , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Wim Van Sebroeck , Guenter Roeck , devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, Chiwoong Byun , Laxman Dewangan References: <20211011155615.257529-1-luca@lucaceresoli.net> <20211011155615.257529-8-luca@lucaceresoli.net> <319589ca-0dfb-008f-052a-01f0f25d86fa@infradead.org> From: Luca Ceresoli Message-ID: Date: Fri, 15 Oct 2021 18:42:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <319589ca-0dfb-008f-052a-01f0f25d86fa@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8BIT X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12/10/21 03:18, Randy Dunlap wrote: > Hi, > > On 10/11/21 8:56 AM, Luca Ceresoli wrote: >> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >> index bf59faeb3de1..00bc3f932a6c 100644 >> --- a/drivers/watchdog/Kconfig >> +++ b/drivers/watchdog/Kconfig >> @@ -699,6 +699,15 @@ config MAX77620_WATCHDOG >>        MAX77620 chips. To compile this driver as a module, >>        choose M here: the module will be called max77620_wdt. >>   +config MAX77714_WATCHDOG >> +    tristate "Maxim MAX77714 Watchdog Timer" >> +    depends on MFD_MAX77714 || COMPILE_TEST >> +    help >> +     This is the driver for watchdog timer in the MAX77714 PMIC. >> +     Say 'Y' here to enable the watchdog timer support for >> +     MAX77714 chips. To compile this driver as a module, >> +     choose M here: the module will be called max77714_wdt. > > Please follow coding-style for Kconfig files: > > (from Documentation/process/coding-style.rst, section 10): > > For all of the Kconfig* configuration files throughout the source tree, > the indentation is somewhat different.  Lines under a ``config`` definition > are indented with one tab, while help text is indented an additional two > spaces. Oh dear, I usually don't make such silly mistakes, apologies. [...some fast typing later...] Uhm, now I noticed many entries in that file have that same mistake. Perhaps I copy-pasted and didn't check. I'll send a patch to fix them too. -- Luca