From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754339AbcHWWDF (ORCPT ); Tue, 23 Aug 2016 18:03:05 -0400 Received: from nm20.bullet.mail.bf1.yahoo.com ([98.139.212.179]:42035 "EHLO nm20.bullet.mail.bf1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcHWWDD (ORCPT ); Tue, 23 Aug 2016 18:03:03 -0400 X-Greylist: delayed 393 seconds by postgrey-1.27 at vger.kernel.org; Tue, 23 Aug 2016 18:03:03 EDT X-Yahoo-Newman-Id: 748359.6482.bm@smtp213.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Gc_p1UkVM1llg.sEABFBJ86K5_s5JIE400RuER9GY6_kYtS aIC8xui8nlYN27Dj4wJJcSZd1bUcSMPgnJNbF5wTZFOYKzepOkLRl8Ly2SXd d6UTrlMlaPrhd3Yxg5aMQY4RtE7SxRPnJSE9Qen6vZewWCV2nCOIxPsufS1X ko3r6gQLAbV96e4lXwuGQgfWmckSQrFRJ_y53qdd3s9EVd6QXA4AoKPFbUe1 NuNRjefms5V5CGjXllCf9A.k.ODsVBrzh3qkNAD0oOQpQLgA77f24OCuPU4u Y1o7sdahcUuYOsl05G4Rg_uQW5DxmEvdMAbJWx8la7LID_vfPzIZJ9En_ifO emvIjtdq0MyCdevlaqWECZWbH2XtU6WZmx.8nC0nLqAslazFbvV.uGaJlRps 4.4nt2wNxGtNflRiVy7E0AuYuxsS3M9mTfhv0EaOvu5NzlqNHgpOpk6hQM.k NhlLEP8.fW_ade_UP6pmYWcHohvaeO9Rycg4LUMSQSIAcrFJh0taSQlb.MND 6Lh1lWeNFlqphIOX4IHKyYWum2eJa9tdDhh0OIKXSSr0P1_lebEr9sw-- X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Subject: Re: [PATCH] Smack: Use memdup_user() rather than duplicating its implementation To: SF Markus Elfring , linux-security-module@vger.kernel.org, James Morris , "Serge E. Hallyn" References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Nicolas Palix From: Casey Schaufler Message-ID: Date: Tue, 23 Aug 2016 14:56:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/21/2016 11:26 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 21 Aug 2016 20:17:36 +0200 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Casey Schaufler Applied to git://github.com/cschaufler/smack-next.git#smack-for-4.9 > --- > security/smack/smackfs.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c > index e249a66..6492fe9 100644 > --- a/security/smack/smackfs.c > +++ b/security/smack/smackfs.c > @@ -2523,14 +2523,9 @@ static ssize_t smk_write_revoke_subj(struct file *file, const char __user *buf, > if (count == 0 || count > SMK_LONGLABEL) > return -EINVAL; > > - data = kzalloc(count, GFP_KERNEL); > - if (data == NULL) > - return -ENOMEM; > - > - if (copy_from_user(data, buf, count) != 0) { > - rc = -EFAULT; > - goto out_data; > - } > + data = memdup_user(buf, count); > + if (IS_ERR(data)) > + return PTR_ERR(data); > > cp = smk_parse_smack(data, count); > if (IS_ERR(cp)) {