From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBC6C4332F for ; Tue, 29 Nov 2022 03:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235552AbiK2Dxz (ORCPT ); Mon, 28 Nov 2022 22:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235549AbiK2Dxx (ORCPT ); Mon, 28 Nov 2022 22:53:53 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 962C24665C for ; Mon, 28 Nov 2022 19:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669694032; x=1701230032; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=V86s8+gnQwUzclhc6VLYszDsc8zsrqnmT+BIX1Zrqfo=; b=hCJyNa5b1Dv2XTXDMAhMgrLjePWVNrYWWdjWsVN4Bg8OnVyYwWoZNLgW 5WOrwti7amA4f21CfgVjhUN35JztTV8eG5s2R8a723nVOs9oRDtTlEaG3 XRwrw+FswF3mNY3gF9wIQonXaeeCi7QybrJryN6EYdG7xqAwlpM+jAadS zC7P0Csp28qpf6GevLpWo9s73C/55cpGJ9Qi98RAR2WIuVLOwIVUbnDxb 8yGiyHWnZk23TL/Gv7/DRF4cnG5t5jc7KewoZNRBWQe+vE0jIXczsUjV9 B9EEkOAJI6FPW1LNGQCTgyTZ0zpMRfYe6AXZaBlDEIDjLyao1L5lM+nOk g==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="316846639" X-IronPort-AV: E=Sophos;i="5.96,202,1665471600"; d="scan'208";a="316846639" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 19:53:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="594114361" X-IronPort-AV: E=Sophos;i="5.96,202,1665471600"; d="scan'208";a="594114361" Received: from allen-box.sh.intel.com (HELO [10.239.159.48]) ([10.239.159.48]) by orsmga003.jf.intel.com with ESMTP; 28 Nov 2022 19:53:45 -0800 Message-ID: Date: Tue, 29 Nov 2022 11:46:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Christoph Hellwig , Kevin Tian , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Suravee Suthikulpanit , Hector Martin , Sven Peter , Rob Clark , Marek Szyprowski , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Yong Wu , Matthias Brugger , Heiko Stuebner , Matthew Rosato , Orson Zhai , Baolin Wang , Chunyan Zhang , Chen-Yu Tsai , Thierry Reding , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 11/20] iommu/fsl_pamu: Add set_platform_dma callback Content-Language: en-US To: Jason Gunthorpe References: <20221128064648.1934720-1-baolu.lu@linux.intel.com> <20221128064648.1934720-12-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/22 10:14 PM, Jason Gunthorpe wrote: > On Mon, Nov 28, 2022 at 02:46:39PM +0800, Lu Baolu wrote: >> This IOMMU driver doesn't support default domain. Add the implementation >> of set_platform_dma callback so that the IOMMU core could return the >> DMA control. >> >> Signed-off-by: Lu Baolu >> --- >> drivers/iommu/fsl_pamu_domain.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c >> index 4408ac3c49b6..b8c716e7c424 100644 >> --- a/drivers/iommu/fsl_pamu_domain.c >> +++ b/drivers/iommu/fsl_pamu_domain.c >> @@ -314,6 +314,14 @@ static void fsl_pamu_detach_device(struct iommu_domain *domain, >> pr_debug("missing fsl,liodn property at %pOF\n", dev->of_node); >> } >> >> +static void fsl_pamu_set_platform_dma(struct device *dev) >> +{ >> + struct iommu_domain *domain = iommu_get_domain_for_dev(dev); >> + >> + if (domain) >> + fsl_pamu_detach_device(domain, dev); >> +} > This is a bit ugly, it would be better to make the previous patch call > set_platform_dma if it is set instead of detach_dev and then these > patches should just rename the driver's fsl_pamu_detach_device to > fsl_pamu_set_platform_dma > > Then the last patch just deletes the op and the core code Yes. That's better. I will update the series. Best regards, baolu