From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0AA3C43460 for ; Tue, 6 Apr 2021 14:07:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99CDF6139C for ; Tue, 6 Apr 2021 14:07:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344907AbhDFOHc (ORCPT ); Tue, 6 Apr 2021 10:07:32 -0400 Received: from smtpcmd01-sp1.aruba.it ([62.149.158.218]:41664 "EHLO smtpcmd01-sp1.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232880AbhDFOHa (ORCPT ); Tue, 6 Apr 2021 10:07:30 -0400 Received: from [192.168.126.129] ([146.241.148.6]) by Aruba Outgoing Smtp with ESMTPSA id TmMSlNqy2TIb1TmMSl6TuV; Tue, 06 Apr 2021 16:07:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1617718041; bh=qnNqa3PMe4bx15r4Is7WmH19xKZdB1p4g61UEusxWAk=; h=Subject:To:From:Date:MIME-Version:Content-Type; b=TWan4RDaktPxYOxjqxMW8xRiNVl6PcK0FCsdTsCq33PVswVzFFzjMBsgBewEp09LX UQqCc7wYOq/8HAboLatFAD5M+2mVABZ4GEv70r67wVD4zjHxnx32qHHIXBYCWvOSIL EdvQbl4uuuDgSyFMGwebUO+aH3o02XZ/OEmWcRxad2HG801OA0ceWAjJIoHYED1O1F I4A///xHzoB5FJV+sGDpiVlwsH0vU1+p6SfhBFzrupVMnbcHad1/Lyiwd1XLJqy1ru mxL4V734WVEWaqDBtbFi7q9xW9d8ccTHi2tcoZicZgoOq72YBr4WHE6viPbcwDVYEK yG1fxLe2xEk7A== Subject: Re: [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings To: =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= Cc: Dmitry Torokhov , Rob Herring , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Henrik Rydberg , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210402161627.2546145-1-giulio.benetti@benettiengineering.com> <20210402161627.2546145-3-giulio.benetti@benettiengineering.com> From: Giulio Benetti Message-ID: Date: Tue, 6 Apr 2021 16:07:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfJtVFEwfrBGwgWRPXTt+otcGFjg32IsmdB3T+rIy/kGUyznTAvNtJeZ1uKEf+AeS7XWdnur8gLRH8KHyct3H8P44GL6xbRbLEEGcJHYEl2irFYMR+EPY PlGJWTZhLl3CLqVvURMXcg3hGC75IuTlHApB0H4Z2C/8gHNRXis8P5oqudvQxrgSpX0EjHMyk9h0CGz7u0jUahNVymk8xXceYPj/g1tFX7paBsEJMCy/OrTd 2f+PawskwYhBhqlmbOnJa4BVuFcuqosINqDEy+1MbL/Q4NFzhoexLFA512jcEXCAOEbrcqDctvHvZ7DhbAPG19uPId+/5oe1Eew4AXKWxQ2X1H8Ja1APWH9m zOKf1zJdvhrAEOP/mR94EeNz8UfimdQG9G1jJeVED/FAOC2ohSe2vqJkZaQRCtVfz33TWd82ppRKFFYt951T/O6STw+3bQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, On 4/6/21 3:37 PM, Jonathan Neuschäfer wrote: > In the binding: >> +properties: >> + compatible: >> + enum: >> + - hycon,hycon-hy4613 >> + - hycon,hycon-hy4614 >> + - hycon,hycon-hy4621 >> + - hycon,hycon-hy4623 >> + - hycon,hycon-hy4633 >> + - hycon,hycon-hy4635 > > In the example: >> + hycon-hy4633@1c { >> + compatible = "hycon,hy4633"; >> + reg = <0x1c>; >> + interrupt-parent = <&gpio2>; >> + interrupts = <5 IRQ_TYPE_EDGE_FALLING>; >> + reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>; >> + }; > > > Rob's devicetree lint bot detected the mismatch in compatible string > here. > > I personally think 'hycon,hy4633' looks better than 'hycon,hycon-hy4633', > because it isn't so redundant. > Thank you, I've realized it after submitting patches and waited for other comments. I've already fixed it the way you've pointed. Kind regards -- Giulio Benetti Benetti Engineering sas > Best regards, > Jonathan Neuschäfer >