linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Mario.Limonciello@dell.com>
To: <andy.shevchenko@gmail.com>
Cc: <dvhart@infradead.org>, <pali.rohar@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>
Subject: RE: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings
Date: Tue, 27 Feb 2018 16:15:04 +0000	[thread overview]
Message-ID: <a7bb6d4240f04d7ba5b1f07a1087ee64@ausx13mpc124.AMER.DELL.COM> (raw)
In-Reply-To: <CAHp75VfS4vif1_S1Z=z2jAZfERmsiqG0h0j5k6zrmjiQwPGekA@mail.gmail.com>

> -----Original Message-----
> From: platform-driver-x86-owner@vger.kernel.org [mailto:platform-driver-x86-
> owner@vger.kernel.org] On Behalf Of Andy Shevchenko
> Sent: Tuesday, February 27, 2018 10:04 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Darren Hart <dvhart@infradead.org>; Pali Rohár <pali.rohar@gmail.com>;
> LKML <linux-kernel@vger.kernel.org>; Platform Driver <platform-driver-
> x86@vger.kernel.org>
> Subject: Re: [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings
> 
> On Tue, Feb 27, 2018 at 5:56 PM, Mario Limonciello
> <mario.limonciello@dell.com> wrote:
> 
> >         /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
> > -          6 bytes of entry */
> > +        * 6 bytes of entry
> > +        */
> 
> I would prefer not to mix with net style, since you are fixing this, perhaps
> 
> /*
>  * 4 ...
>  * 6 ...
>  */
> 
> ?
> 
Thanks, will adjust again when I resubmit with changes for 3/3.

      reply	other threads:[~2018-02-27 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 15:56 [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings Mario Limonciello
2018-02-27 15:56 ` [PATCH 2/3] platform/x86: dell-smbios: Rename dell-smbios source to dell-smbios-base Mario Limonciello
2018-02-27 15:56 ` [PATCH 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together Mario Limonciello
2018-02-27 16:08   ` Andy Shevchenko
2018-02-27 16:13     ` Mario.Limonciello
2018-02-27 16:16       ` Andy Shevchenko
2018-02-27 16:04 ` [PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings Andy Shevchenko
2018-02-27 16:15   ` Mario.Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7bb6d4240f04d7ba5b1f07a1087ee64@ausx13mpc124.AMER.DELL.COM \
    --to=mario.limonciello@dell.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).