From: Jonathan Cameron <jic23@kernel.org>
To: Brian Masney <masneyb@onstation.org>, linux-iio@vger.kernel.org
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com
Subject: Re: [PATCH v3 0/2] staging: iio: isl29028: move out of staging
Date: Wed, 26 Apr 2017 06:25:31 +0100 [thread overview]
Message-ID: <a7da92e0-07de-f8ed-99e9-3097cc43e394@kernel.org> (raw)
In-Reply-To: <20170425013434.1206-1-masneyb@onstation.org>
On 25/04/17 02:34, Brian Masney wrote:
> Minor cleanup to the proximity sampling to move this driver out of
> staging.
>
> Datasheet:
> http://www.intersil.com/content/dam/Intersil/documents/isl2/isl29028.pdf
>
> Changes since v2:
> - Reject any value that is not in the
> in_proximity_sampling_frequency_available sysfs attribute.
> - Changed the sampling frequency 83.3 to 80. The data sheet lists 12.5
> ms, but the original code listed 12 ms, which was the cause of the
> discrepancy.
> Changes since v1:
> - in_proximity_sampling_frequency_available sysfs attribute now shows
> decimals.
>
> Jonathan: Sorry it took me a little over two months to get back to you
> on this driver. I got side tracked with other projects.
*laughs* I have series that I haven't gotten back to reviews on in
years! What's a few months ;)
Thanks though as this work is good stuff!
Jonathan
>
> Brian Masney (2):
> staging: iio: isl29028: correct proximity sleep times
> staging: iio: isl29028: move out of staging
>
> drivers/iio/light/Kconfig | 10 +
> drivers/iio/light/Makefile | 1 +
> drivers/iio/light/isl29028.c | 723 +++++++++++++++++++++++++++++++++++
> drivers/staging/iio/light/Kconfig | 10 -
> drivers/staging/iio/light/Makefile | 1 -
> drivers/staging/iio/light/isl29028.c | 693 ---------------------------------
> 6 files changed, 734 insertions(+), 704 deletions(-)
> create mode 100644 drivers/iio/light/isl29028.c
> delete mode 100644 drivers/staging/iio/light/isl29028.c
>
prev parent reply other threads:[~2017-04-26 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 1:34 [PATCH v3 0/2] staging: iio: isl29028: move out of staging Brian Masney
2017-04-25 1:34 ` [PATCH v3 1/2] staging: iio: isl29028: correct proximity sleep times Brian Masney
2017-04-26 5:30 ` Jonathan Cameron
2017-04-25 1:34 ` [PATCH v3 2/2] staging: iio: isl29028: move out of staging Brian Masney
2017-04-26 5:30 ` Jonathan Cameron
2017-04-26 5:49 ` Joe Perches
2017-04-26 6:03 ` Jonathan Cameron
2017-04-26 5:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7da92e0-07de-f8ed-99e9-3097cc43e394@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).