From: cang@codeaurora.org
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com, "James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-kernel@vger.kernel.org, Can Guo <cang@codeaurora.org>
Subject: Re: [PATCH v3 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD
Date: Wed, 13 Nov 2019 11:22:25 +0800 [thread overview]
Message-ID: <a7e85a27f08d571b6c70421784d6fd05@codeaurora.org> (raw)
In-Reply-To: <yq1tv78pjdz.fsf@oracle.com>
On 2019-11-13 11:03, Martin K. Petersen wrote:
> Can,
>
>> Host sends MODE_SENSE_10 with caching mode page, to check if the
>> device supports the cache feature. UFS JEDEC standards require DBD
>> field to be set to 1.
>
> UFS requires DBD for all MODE SENSE(10) invocations, not just for
> accessing the caching mode page. I think the flag name needs to reflect
> this.
>
> Also, I do not particularly like this being a scsi_host flag. All the
> other flags we have in this department are per scsi_device.
>
> My recommendation would be to add a set_dbd_for_ms flag to struct
> scsi_device and then do:
>
> sdev->set_dbd_for_ms = 1;
>
> in ufshcd_slave_alloc() mirroring the existing:
>
> sdev->use_10_for_ms = 1;
>
> This makes the MODE SENSE tweakery consistent.
>
> Thanks!
Hi Martin,
Thank you, good idea. I will make the change in your way.
Best regards,
Can Guo.
next prev parent reply other threads:[~2019-11-13 3:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1572670898-750-1-git-send-email-cang@codeaurora.org>
2019-11-02 5:01 ` [PATCH v3 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD Can Guo
2019-11-03 21:16 ` [EXT] " Bean Huo (beanhuo)
2019-11-13 3:03 ` Martin K. Petersen
2019-11-13 3:22 ` cang [this message]
2019-11-02 5:01 ` [PATCH v3 2/5] scsi: ufs: Set DBD setting in mode sense for caching mode page Can Guo
2019-11-03 21:17 ` [EXT] " Bean Huo (beanhuo)
2019-11-02 5:01 ` [PATCH v3 3/5] scsi: ufs: Release clock if DMA map fails Can Guo
2019-11-02 5:01 ` [PATCH v3 4/5] scsi: ufs: Do not clear the DL layer timers Can Guo
2019-11-02 5:01 ` [PATCH v3 5/5] scsi: ufs: Do not free irq in suspend Can Guo
[not found] <1572657631-25749-1-git-send-email-cang@qti.qualcomm.com>
2019-11-02 1:20 ` [PATCH v3 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7e85a27f08d571b6c70421784d6fd05@codeaurora.org \
--to=cang@codeaurora.org \
--cc=asutoshd@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).