From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B282CC433EF for ; Thu, 9 Jun 2022 19:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236284AbiFITIe (ORCPT ); Thu, 9 Jun 2022 15:08:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231907AbiFITIb (ORCPT ); Thu, 9 Jun 2022 15:08:31 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD14C26CE49; Thu, 9 Jun 2022 12:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654801710; x=1686337710; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=c38Un+y998cp1mk//MudRgxdikF4s6RsjatPEg81vl0=; b=F05Oe/n/LDmEbUvDAFeOAiOuCAhMxvF7TtNLkWTaRXL0DC8KVnhNUgNl VDr1S9CYE1GcG1w5Gk/Lwun1CCPeKxbTnEY2BHnf8fre3mxtXYX4CBgRl eiF6eg3h4pYxhVSZ59S23mLYMA6Fj+U6Mvw5ITc05mpsgocZxh3he4oPC guVJt9rRMgZ5JpLkQFsg8XeVJyGgGzTfBCxTRtwTs4iaeeTRDDnNiXrbS Izag7k/RYuJLeB0SPKqpubeAs+tNZAjTsqRstCgw9u6U5MBiWYpCdh+9m MXFp5aVN/a+pjHk/dmhAnFoSvSeNjKW0ZBGSTwb5fglEiue7XtzQS7MFu A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="278533566" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="278533566" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 12:08:14 -0700 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="585751984" Received: from jeremywe-mobl3.amr.corp.intel.com (HELO [10.209.173.145]) ([10.209.173.145]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 12:08:12 -0700 Message-ID: Date: Thu, 9 Jun 2022 14:08:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH v1 14/16] soundwire: Use acpi_dev_for_each_child() Content-Language: en-US To: "Rafael J. Wysocki" Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux PM , Bard Liao , "Rafael J. Wysocki" , LKML , Linux ACPI , Vinod Koul , Hans de Goede , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Mika Westerberg References: <1843211.tdWV9SEqCh@kreacher> <5296779.Sb9uPGUboI@kreacher> <63d7f3ed-b5a9-c869-5d25-a33a1d4e63c8@linux.intel.com> <7652ddab-53a5-ac8e-33f5-d25527acb1a6@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/22 12:35, Rafael J. Wysocki wrote: > On Thu, Jun 9, 2022 at 6:21 PM Pierre-Louis Bossart > wrote: >> >> >>>> Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with >>>> >>>> return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus); >>> >>> Sure, I'll do that. Thanks! >> >> I also added this EXPORT_SYMBOL to work-around link errors, not sure if >> this is in your tree already? > > One of the previous patches in the series is adding the export. ok. I ran a bunch of tests with those two changes, so feel free to take my tags: Reviewed-by: Pierre-Louis Bossart Tested-by: Pierre-Louis Bossart