From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>
Subject: Re: [PATCH net-next v1] net: Use csum_replace_... and csum_sub() helpers instead of opencoding
Date: Thu, 17 Feb 2022 18:39:07 +0000 [thread overview]
Message-ID: <a7fe3817-a9ed-fb48-c3ab-1d17e8961e7f@csgroup.eu> (raw)
In-Reply-To: <20220217101442.0a2805b6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Le 17/02/2022 à 19:14, Jakub Kicinski a écrit :
> On Thu, 17 Feb 2022 18:11:58 +0000 Christophe Leroy wrote:
>> Looks like csum_replace4() expects __be32 inputs, I'll look at it but
>> I'm not inclined at adding force cast, so will probably leave
>> nft_csum_replace() as is.
>
> That may imply also leaving it in your tree..
By "leave as is" I meant I'll drop the change.
I'll send v2 without this hunk.
Christophe
next prev parent reply other threads:[~2022-02-17 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 15:43 [PATCH net-next v1] net: Use csum_replace_... and csum_sub() helpers instead of opencoding Christophe Leroy
2022-02-17 17:24 ` Jakub Kicinski
2022-02-17 18:11 ` Christophe Leroy
2022-02-17 18:14 ` Jakub Kicinski
2022-02-17 18:39 ` Christophe Leroy [this message]
2022-02-17 18:54 ` Jakub Kicinski
2022-02-18 7:43 ` kernel test robot
2022-04-22 11:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7fe3817-a9ed-fb48-c3ab-1d17e8961e7f@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).