From: Chao Yu <yuchao0@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <jaegeuk@kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <chao@kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] f2fs: fix out-of-repair __setattr_copy()
Date: Thu, 17 Dec 2020 14:51:55 +0800 [thread overview]
Message-ID: <a8291621-e472-5b00-d2b3-8d8016386e47@huawei.com> (raw)
In-Reply-To: <X9nXCdp1ssMHKdNI@kroah.com>
On 2020/12/16 17:44, Greg KH wrote:
> On Wed, Dec 16, 2020 at 05:15:23PM +0800, Chao Yu wrote:
>> __setattr_copy() was copied from setattr_copy() in fs/attr.c, there is
>> two missing patches doesn't cover this inner function, fix it.
>>
>> Commit 7fa294c8991c ("userns: Allow chown and setgid preservation")
>> Commit 23adbe12ef7d ("fs,userns: Change inode_capable to capable_wrt_inode_uidgid")
>
> Are these lines supposed to be "Fixes:" instead of "Commit "?
IMO, the issue was introduced when f2fs module was added, and above two commits
missed to cover f2fs module... so I guess we can add Fixes line as below?
Fixes: fbfa2cc58d53 ("f2fs: add file operations")
Thanks,
>
> thanks,
>
> greg k-h
> .
>
prev parent reply other threads:[~2020-12-17 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 9:15 [PATCH] f2fs: fix out-of-repair __setattr_copy() Chao Yu
2020-12-16 9:44 ` Greg KH
2020-12-17 6:51 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8291621-e472-5b00-d2b3-8d8016386e47@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).