From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556AbcG2SWF (ORCPT ); Fri, 29 Jul 2016 14:22:05 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:46102 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752988AbcG2SWA convert rfc822-to-8bit (ORCPT ); Fri, 29 Jul 2016 14:22:00 -0400 Authentication-Results: ppops.net; spf=pass smtp.mailfrom=Paul.Handrigan@cirrus.com From: "Handrigan, Paul" To: Nicolin Chen , "broonie@kernel.org" CC: "lgirdwood@gmail.com" , "Austin, Brian" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" Subject: Re: [PATCH] ASoC: cs53l30: Do not ignore errors if mclk is specified Thread-Topic: [PATCH] ASoC: cs53l30: Do not ignore errors if mclk is specified Thread-Index: AQHR6SFr3pxptvRBzUWrHYBb8T6VBaAvuecA Date: Fri, 29 Jul 2016 18:21:50 +0000 Message-ID: In-Reply-To: <1469745781-31057-1-git-send-email-nicoleotsuka@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.5.130515 x-originating-ip: [141.131.38.212] Content-Type: text/plain; charset="us-ascii" Content-ID: <36BE31E2CB44F84F8CD80F47E11A63E7@ad.cirrus.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com ip4:141.131.128.20 ip4:141.131.3.20 ip4:213.128.236.230 ip4:87.246.98.25 ip4:87.246.78.26 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1607290182 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/16, 5:43 PM, "Nicolin Chen" wrote: >When the clock is specified, there could be other errors besides >the EPROBE_DEFER so don't ignore them. > >Signed-off-by: Nicolin Chen >--- > sound/soc/codecs/cs53l30.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c >index 2c0d9c4..227c556 100644 >--- a/sound/soc/codecs/cs53l30.c >+++ b/sound/soc/codecs/cs53l30.c >@@ -999,8 +999,8 @@ static int cs53l30_i2c_probe(struct i2c_client >*client, > /* Check if MCLK provided */ > cs53l30->mclk = devm_clk_get(dev, "mclk"); > if (IS_ERR(cs53l30->mclk)) { >- if (PTR_ERR(cs53l30->mclk) == -EPROBE_DEFER) { >- ret = -EPROBE_DEFER; >+ if (PTR_ERR(cs53l30->mclk) != -ENOENT) { >+ ret = PTR_ERR(cs53l30->mclk); > goto error; > } > /* Otherwise mark the mclk pointer to NULL */ Acked-by: Paul Handrigan