From: David Hildenbrand <david@redhat.com>
To: Zhao Gongyi <zhaogongyi@huawei.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Cc: akinobu.mita@gmail.com, corbet@lwn.net, osalvador@suse.de,
shuah@kernel.org
Subject: Re: [PATCH -next v3 1/3] selftests/memory-hotplug: Add checking after online or offline
Date: Mon, 26 Sep 2022 15:27:07 +0200 [thread overview]
Message-ID: <a889576f-0178-b44f-16b0-fdeafbe01035@redhat.com> (raw)
In-Reply-To: <20220926130341.253039-2-zhaogongyi@huawei.com>
On 26.09.22 15:03, Zhao Gongyi wrote:
> Add checking for online_memory_expect_success()/
> offline_memory_expect_success()/offline_memory_expect_fail(), or
> the test would exit 0 although the functions return 1.
>
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> .../selftests/memory-hotplug/mem-on-off-test.sh | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 46a97f318f58..3edda1f13f7b 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -266,7 +266,10 @@ done
> #
> echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error
> for memory in `hotpluggable_offline_memory`; do
> - online_memory_expect_fail $memory
> + online_memory_expect_fail $memory || {
> + echo "online memory $memory: unexpected success"
The functions themself already print an error, isn't it sufficient to
set retval=1?
> + retval=1
> + }
> done
>
> #
> @@ -274,7 +277,10 @@ done
> #
> echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error
> for memory in `hotpluggable_offline_memory`; do
> - online_memory_expect_success $memory
> + online_memory_expect_success $memory || {
> + echo "online memory $memory: unexpected fail"
> + retval=1
> + }
> done
>
> #
> @@ -283,7 +289,10 @@ done
> echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
> for memory in `hotpluggable_online_memory`; do
> if [ $((RANDOM % 100)) -lt $ratio ]; then
> - offline_memory_expect_fail $memory
> + offline_memory_expect_fail $memory || {
> + echo "offline memory $memory: unexpected success"
> + retval=1
> + }
These functions return 0 if the result is as expected and 1 if the
result is unexpected.
... but wouldn't we evaluate the right hand side only if the result is
"0" -- expected? I might be wrong.
Wouldn't it be simpler do it as in "Online all hot-pluggable memory again"
if ! online_memory_expect_success $memory; then
retval=1
fi
(similarly adjusting the function name)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-26 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 13:03 [PATCH -next v3 0/3] Optimize and bugfix for memory-hotplug Zhao Gongyi
2022-09-26 13:03 ` [PATCH -next v3 1/3] selftests/memory-hotplug: Add checking after online or offline Zhao Gongyi
2022-09-26 13:27 ` David Hildenbrand [this message]
2022-09-26 13:03 ` [PATCH -next v3 2/3] selftests/memory-hotplug: Restore memory before exit Zhao Gongyi
2022-09-26 13:03 ` [PATCH -next v3 3/3] docs: notifier-error-inject: Correct test's name Zhao Gongyi
2022-09-27 1:36 [PATCH -next v3 1/3] selftests/memory-hotplug: Add checking after online or offline zhaogongyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a889576f-0178-b44f-16b0-fdeafbe01035@redhat.com \
--to=david@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).