From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Konrad Rzeszutek Wilk <konrad@darnok.org>,
Halil Pasic <pasic@linux.ibm.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Heiko Carstens <hca@linux.ibm.com>,
stable@vger.kernel.org, Claire Chang <tientzu@chromium.org>,
Will Deacon <will@kernel.org>, Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/1] s390/pv: fix the forcing of the swiotlb
Date: Tue, 27 Jul 2021 14:54:14 +0200 [thread overview]
Message-ID: <a89f1add-b0fb-1069-cb30-78864e399b19@de.ibm.com> (raw)
In-Reply-To: <YPtejB62iu+iNrM+@fedora>
On 24.07.21 02:27, Konrad Rzeszutek Wilk wrote:
> On Sat, Jul 24, 2021 at 01:17:46AM +0200, Halil Pasic wrote:
>> Since commit 903cd0f315fe ("swiotlb: Use is_swiotlb_force_bounce for
>> swiotlb data bouncing") if code sets swiotlb_force it needs to do so
>> before the swiotlb is initialised. Otherwise
>> io_tlb_default_mem->force_bounce will not get set to true, and devices
>> that use (the default) swiotlb will not bounce despite switolb_force
>> having the value of SWIOTLB_FORCE.
>>
>> Let us restore swiotlb functionality for PV by fulfilling this new
>> requirement.
>>
>> This change addresses what turned out to be a fragility in
>> commit 64e1f0c531d1 ("s390/mm: force swiotlb for protected
>> virtualization"), which ain't exactly broken in its original context,
>> but could give us some more headache if people backport the broken
>> change and forget this fix.
>>
>> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
>> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Fixes: 903cd0f315fe ("swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing")
>> Fixes: 64e1f0c531d1 ("s390/mm: force swiotlb for protected virtualization")
>> Cc: stable@vger.kernel.org #5.3+
>>
>> ---
>
> Picked it up and stuck it in linux-next with the other set of patches (Will's fixes).
Can you push out to kernel.org?
next prev parent reply other threads:[~2021-07-27 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 23:17 [PATCH v2 1/1] s390/pv: fix the forcing of the swiotlb Halil Pasic
2021-07-24 0:27 ` Konrad Rzeszutek Wilk
2021-07-26 15:25 ` Halil Pasic
2021-07-27 12:54 ` Christian Borntraeger [this message]
2021-07-27 12:57 ` Will Deacon
2021-07-27 13:00 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89f1add-b0fb-1069-cb30-78864e399b19@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nathan@kernel.org \
--cc=pasic@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=tientzu@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).