From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69109C433E2 for ; Tue, 1 Sep 2020 06:58:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DE8220FC3 for ; Tue, 1 Sep 2020 06:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbgIAG6J (ORCPT ); Tue, 1 Sep 2020 02:58:09 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:45332 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726085AbgIAG6H (ORCPT ); Tue, 1 Sep 2020 02:58:07 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E5F782469EB139DBFF69; Tue, 1 Sep 2020 14:58:03 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Tue, 1 Sep 2020 14:58:00 +0800 Subject: Re: [PATCH -next] memory: omap-gpmc: Fix -Wunused-function warnings To: Krzysztof Kozlowski References: <20200901035642.22772-1-yuehaibing@huawei.com> <20200901065241.GA7720@kozik-lap> CC: , , , From: Yuehaibing Message-ID: Date: Tue, 1 Sep 2020 14:58:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200901065241.GA7720@kozik-lap> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/1 14:52, Krzysztof Kozlowski wrote: > On Tue, Sep 01, 2020 at 11:56:42AM +0800, YueHaibing wrote: >> drivers/memory/omap-gpmc.c:987:12: warning: ‘gpmc_cs_remap’ defined but not used [-Wunused-function] >> static int gpmc_cs_remap(int cs, u32 base) >> ^~~~~~~~~~~~~ >> drivers/memory/omap-gpmc.c:926:20: warning: ‘gpmc_cs_get_name’ defined but not used [-Wunused-function] >> static const char *gpmc_cs_get_name(int cs) >> ^~~~~~~~~~~~~~~~ >> drivers/memory/omap-gpmc.c:919:13: warning: ‘gpmc_cs_set_name’ defined but not used [-Wunused-function] >> static void gpmc_cs_set_name(int cs, const char *name) >> ^~~~~~~~~~~~~~~~ >> Make them as __maybe_unused to fix this. > > Hi, > > Do you know what configuration triggers these warnings? What has to be > disabled (e.g. CONFIG_OF)? Such information is useful in the commit > message. Yes, this is triggered by disable CONFIG_OF, I will update the commit log. > > Best regards, > Krzysztof > > . >