From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751988AbdEBHLy (ORCPT ); Tue, 2 May 2017 03:11:54 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:35613 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbdEBHLv (ORCPT ); Tue, 2 May 2017 03:11:51 -0400 Subject: Re: [PATCH 2/2] efi/efi_test: drop useless kfree To: Geliang Tang References: <427b03b5f10b41014818b9e78f79da9581b213df.1493383416.git.geliangtang@gmail.com> Cc: Matt Fleming , Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org From: ivanhu Message-ID: Date: Tue, 2 May 2017 15:11:45 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <427b03b5f10b41014818b9e78f79da9581b213df.1493383416.git.geliangtang@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/29/2017 09:42 AM, Geliang Tang wrote: > Drop useless kfree when memdup_user() failed, since we have already > called kfree in memdup_user(). > > Signed-off-by: Geliang Tang > --- > drivers/firmware/efi/test/efi_test.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c > index 08129b7..00332ae 100644 > --- a/drivers/firmware/efi/test/efi_test.c > +++ b/drivers/firmware/efi/test/efi_test.c > @@ -261,10 +261,8 @@ static long efi_runtime_set_variable(unsigned long arg) > } > > data = memdup_user(setvariable.data, setvariable.data_size); > - if (IS_ERR(data)) { > - kfree(name); You mean "name" or "data"? Cheers, Ivan > + if (IS_ERR(data)) > return PTR_ERR(data); > - } > > status = efi.set_variable(name, &vendor_guid, > setvariable.attributes,