From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756236AbdKDInp (ORCPT ); Sat, 4 Nov 2017 04:43:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:46159 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753201AbdKDInm (ORCPT ); Sat, 4 Nov 2017 04:43:42 -0400 Subject: Re: [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes To: Manivannan Sadhasivam Cc: mturquette@baylibre.com, sboyd@codeaurora.org, robh+dt@kernel.org, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, rdunlap@infradead.org, daniel.thompson@linaro.org, amit.kucheria@linaro.org, liuwei@actions-semi.com References: <1509479663-8985-1-git-send-email-manivannan.sadhasivam@linaro.org> <1509479663-8985-2-git-send-email-manivannan.sadhasivam@linaro.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: Date: Sat, 4 Nov 2017 16:43:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509479663-8985-2-git-send-email-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam: > This patch adds clock controller nodes for Actions Semi s900 SoC Please avoid "This patch". Once applied, it's a commit. :) > > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm64/boot/dts/actions/s900.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi > index 11406f6..c099ef1 100644 > --- a/arch/arm64/boot/dts/actions/s900.dtsi > +++ b/arch/arm64/boot/dts/actions/s900.dtsi > @@ -5,6 +5,7 @@ > */ > > #include > +#include Alphabetical order please. > > / { > compatible = "actions,s900"; > @@ -88,6 +89,24 @@ > #clock-cells = <0>; > }; > > + losc: losc { > + compatible = "fixed-clock"; > + clock-frequency = <32768>; > + #clock-cells = <0>; > + }; > + > + diff_24M: diff_24M { No underscore in node names please - maybe diff-24M or simpler diff24M? Please double-check that name - is it from manual or from schematics? > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + #clock-cells = <0>; > + }; > + > + clock: clock-controller@e0160000 { > + compatible = "actions,s900-clock"; > + reg = <0 0xe0160000 0 0x1000>; > + #clock-cells = <1>; > + }; This node belongs into the soc node below, ordered by unit address. And maybe there's a better label than "clock"? "clkc" or some official name from the manual? > + > soc { > compatible = "simple-bus"; > #address-cells = <2>; Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)