linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chun-Jie Chen <chun-jie.chen@mediatek.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nicolas Boichat <drinkcat@chromium.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Project_Global_Chrome_Upstream_Group 
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [v3 5/5] soc: mediatek: pm-domains: Remove unused macro
Date: Mon, 26 Jul 2021 19:31:16 +0800	[thread overview]
Message-ID: <a8c0bd3cba8731fefac0678fe25d0482b8ed8b13.camel@mediatek.com> (raw)
In-Reply-To: <CAGXv+5ETE=qSPyKL6AjDtSHCDvu3Ua-rrLZWOECjZXrcNZ-9Tw@mail.gmail.com>

On Thu, 2021-07-15 at 14:40 +0800, Chen-Yu Tsai wrote:
> On Mon, Jul 5, 2021 at 1:48 PM Chun-Jie Chen <
> chun-jie.chen@mediatek.com> wrote:
> > 
> > Due to clk resource data will be allocated dynamically by
> > searching parent count of clk in power domain node, so remove
> > the unused marco MAX_SUBSYS_CLKS for static allocation.
> > 
> > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >  drivers/soc/mediatek/mtk-pm-domains.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h
> > b/drivers/soc/mediatek/mtk-pm-domains.h
> > index caaa38100093..1b8967b9829e 100644
> > --- a/drivers/soc/mediatek/mtk-pm-domains.h
> > +++ b/drivers/soc/mediatek/mtk-pm-domains.h
> > @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data {
> >         bool ignore_clr_ack;
> >  };
> > 
> > -#define MAX_SUBSYS_CLKS 10
> > -
> 
> Future advice: cleanups like this and other fixes should be put in
> the
> front of the series, before any patches that introduce support for
> new
> features or hardware. That way if the new code still needs work,
> maintainers can optionally apply the fixes so you don't have to carry
> a large patch series forward.
> 
> ChenYu
> 
Ok, I will re-order the patches in next series.
Thanks for your comment.

Best Regards,
Chun-Jie

> >  /**
> >   * struct scpsys_domain_data - scp domain data for power on/off
> > flow
> >   * @name: The name of the power domain.
> > --
> > 2.18.0
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > 
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!2l_6i-Mdrf270eVKoo59clCnOVZoi5wlBEuHFAfriTvaSsrv6Loc8HJbt7K8LexIJWuR$
> >  

      reply	other threads:[~2021-07-26 11:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210705054111.4473-1-chun-jie.chen@mediatek.com>
2021-07-05  5:41 ` [v3 1/5] soc: mediatek: pm-domains: Move power status offset to power domain data Chun-Jie Chen
2021-07-05  5:41 ` [v3 2/5] dt-bindings: power: Add MT8195 power domains Chun-Jie Chen
2021-07-05  5:41 ` [v3 3/5] soc: mediatek: pm-domains: Add support for mt8195 Chun-Jie Chen
2021-07-20  8:51   ` Chen-Yu Tsai
2021-07-30  3:12     ` Chun-Jie Chen
2021-07-30  4:20       ` Chen-Yu Tsai
2021-08-17  1:07         ` Chun-Jie Chen
2021-07-05  5:41 ` [v3 4/5] soc: mediatek: pm-domains: Add wakeup capacity support in power domain Chun-Jie Chen
2021-07-20  9:01   ` Chen-Yu Tsai
2021-07-05  5:41 ` [v3 5/5] soc: mediatek: pm-domains: Remove unused macro Chun-Jie Chen
2021-07-15  6:40   ` Chen-Yu Tsai
2021-07-26 11:31     ` Chun-Jie Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8c0bd3cba8731fefac0678fe25d0482b8ed8b13.camel@mediatek.com \
    --to=chun-jie.chen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=wenst@chromium.org \
    --subject='Re: [v3 5/5] soc: mediatek: pm-domains: Remove unused macro' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).