From: David Ahern <dsahern@gmail.com>
To: Riccardo Paolo Bestetti <pbl@bestov.io>,
Denis Kirjanov <dkirjanov@suse.de>
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2] ipv4/raw: support binding to nonlocal addresses
Date: Wed, 17 Nov 2021 20:59:16 -0700 [thread overview]
Message-ID: <a8d9f99d-8aa8-3186-fcca-c0f7b7f37327@gmail.com> (raw)
In-Reply-To: <CFSH0AY7X60L.1KW9K4CV82NQG@enhorning>
On 11/17/21 5:14 PM, Riccardo Paolo Bestetti wrote:
>>> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
>>> index 1e44a43acfe2..e540b0dcf085 100644
>>> --- a/net/ipv4/ping.c
>>> +++ b/net/ipv4/ping.c
>>> @@ -311,15 +311,11 @@ static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
>>> pr_debug("ping_check_bind_addr(sk=%p,addr=%pI4,port=%d)\n",
>>> sk, &addr->sin_addr.s_addr, ntohs(addr->sin_port));
>>>
>>> - if (addr->sin_addr.s_addr == htonl(INADDR_ANY))
>>> - chk_addr_ret = RTN_LOCAL;
>>> - else
>>> - chk_addr_ret = inet_addr_type(net, addr->sin_addr.s_addr);
>>
>> That was done intentionally in commit 0ce779a9f501
>>
>
> Should I remove this from the patch? Is there a particular reason why
> this was done in ping.c but not in the other places?
>
exactly. I did not see the big deal about changing it.
next prev parent reply other threads:[~2021-11-18 3:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 0:20 [PATCH] ipv4/raw: support binding to nonlocal addresses Riccardo Paolo Bestetti
2021-03-21 17:06 ` David Ahern
2021-11-02 14:19 ` [PATCH v2] " Riccardo Paolo Bestetti
2021-11-04 15:59 ` David Ahern
2021-11-04 17:34 ` Jakub Kicinski
2021-11-17 9:00 ` Riccardo Paolo Bestetti
2021-11-17 15:14 ` Denis Kirjanov
2021-11-18 0:14 ` Riccardo Paolo Bestetti
2021-11-18 3:59 ` David Ahern [this message]
2021-11-18 4:23 ` Jakub Kicinski
[not found] ` <CFPVQWNG02LG.3DHWUZ0JCAMVS@enhorning>
2021-11-17 3:44 ` Jakub Kicinski
2021-11-17 8:05 ` Riccardo Paolo Bestetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8d9f99d-8aa8-3186-fcca-c0f7b7f37327@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pbl@bestov.io \
--cc=shuah@kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).