From: "dave young" <hidave.darkstar@gmail.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: "Willy Tarreau" <w@1wt.eu>,
"Cyrill Gorcunov" <gorcunov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"Randy Dunlap" <randy.dunlap@oracle.com>
Subject: Re: coding style
Date: Fri, 15 Jun 2007 06:38:54 +0000 [thread overview]
Message-ID: <a8e1da0706142338s6cd76e94hf7a4c44ed5b067a0@mail.gmail.com> (raw)
In-Reply-To: <46721F18.8090303@intel.com>
Hi,
The Documentation/CodingStyle says:
Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation, and the above example is deliberately broken.
Regards
dave
2007/6/15, Kok, Auke <auke-jan.h.kok@intel.com>:
> Willy Tarreau wrote:
> > On Thu, Jun 14, 2007 at 10:48:36PM +0400, Cyrill Gorcunov wrote:
> >> Hi to all,
> >>
> >> a simple question the answer to witch I didn't find in CodingStyle.
> >> Look for a code snip:
> >>
> >> err = foo(arg_a, arg_b, arg_c,
> >> arg_d);
> >>
> >> the second line contains 'd' arg aligned with tabs only
> >> but it could be rewritten with more elegant style (by adding
> >> a few spaces) like this
> >>
> >> err = foo(arg_a, arg_b, arg_c,
> >> arg_d);
> >>
> >> so which one is preferred for the kernel?
> >
> > There is no "preferred", just one good and one bad :-)
> >
> > Ideally, you should use tabs only for indentation, and spaces only for
> > alignment. Keep in mind that there are people using different tab sizes
> > and that your tabs should not make it harder for them to read your code.
> > In your example above, you should use tabs from left up to "err", then
> > spaces to go from "err" to "arg_d".
> >
> > However, we know that some editors such as emacs are stupid in this regard,
> > because they fill with tabs then complete with spaces, so it's not always
> > easy.
>
> the current "checkpatch.pl" script rejects this notion and requires that you use
> tabs whenever you can (you can still align code within the length of one tab).
>
> Since in the example part (2) above there are 9 spaces needed to go from err to
> arg_d, it complains if you had used 9 spaces here. It only allows you to use
> tabs + n spaces (where n < 8)
>
> I personally prefer spaces, but the checkpatch.pl script does not agree, much to
> my dismay :(
>
>
> Auke
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2007-06-15 6:39 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 18:48 coding style Cyrill Gorcunov
2007-06-15 4:51 ` Willy Tarreau
2007-06-15 5:09 ` Kok, Auke
2007-06-15 6:38 ` dave young [this message]
2007-06-15 6:47 ` debian developer
2007-06-15 6:54 ` dave young
2007-06-15 9:06 ` Mailing style (was Re: coding style) Bernd Petrovitsch
2007-06-15 9:19 ` debian developer
2007-06-15 9:16 ` coding style Jan Engelhardt
2007-06-15 17:32 ` Cyrill Gorcunov
2007-06-15 17:54 ` Chris Friesen
2007-06-15 18:03 ` Randy Dunlap
2007-06-15 19:10 ` Jan Engelhardt
2007-06-15 19:18 ` Cyrill Gorcunov
2007-06-15 19:21 ` Kok, Auke
2007-06-15 19:29 ` Cyrill Gorcunov
2007-06-15 19:31 ` Jan Engelhardt
2007-06-15 19:41 ` Cyrill Gorcunov
2007-06-15 20:21 ` Linus Torvalds
2007-06-15 20:35 ` Jan Engelhardt
2007-06-16 12:30 ` Stefan Richter
2007-06-15 20:21 ` Jan Engelhardt
2007-06-15 20:39 ` Linus Torvalds
2007-06-16 6:38 ` Jan Engelhardt
2007-06-16 12:40 ` Stefan Richter
2007-06-16 15:49 ` Linus Torvalds
2007-06-19 14:05 ` Mark Lord
2007-06-15 19:45 ` Kok, Auke
2007-06-15 19:49 ` Cyrill Gorcunov
2007-06-15 20:28 ` Jan Engelhardt
2007-06-15 22:10 ` Randy Dunlap
2007-06-16 12:59 ` please keep the CodingStyle text in check (was Re: coding style) Stefan Richter
2007-06-15 18:05 ` coding style Kok, Auke
2007-06-15 18:22 ` Cyrill Gorcunov
2007-06-16 13:07 ` Stefan Richter
2007-06-16 14:31 ` gorcunov
2007-06-16 17:43 ` Stefan Richter
2007-06-16 18:22 ` Cyrill Gorcunov
2007-06-16 14:22 ` Clifford Wolf
2007-06-15 8:56 ` Krzysztof Halasa
-- strict thread matches above, loose matches on Subject: below --
2001-01-23 15:07 Coding Style Jonathan Earle
2001-01-24 3:23 ` john slee
[not found] <Pine.LNX.4.10.10101192217390.9361-100000@penguin.transmeta .com>
[not found] ` <3A68E309.2540A5E1@purplecoder.com>
2001-01-20 6:29 ` Linus Torvalds
2001-01-20 15:32 ` Anton Altaparmakov
2001-01-21 8:24 ` george anzinger
2001-01-19 17:59 Mark I Manning IV
2001-01-20 0:09 ` David Ford
2001-01-20 1:26 ` John Cavan
2001-01-20 0:46 ` Albert D. Cahalan
2001-01-20 5:34 ` Linus Torvalds
2001-01-21 2:00 ` Matthias Andree
2001-01-22 8:24 ` Ralf Baechle
2001-01-22 22:28 ` Mark I Manning IV
2001-01-23 3:56 ` adrian
2001-01-23 20:05 ` Boris Dragovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e1da0706142338s6cd76e94hf7a4c44ed5b067a0@mail.gmail.com \
--to=hidave.darkstar@gmail.com \
--cc=auke-jan.h.kok@intel.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).