From: Randy Dunlap <rdunlap@infradead.org>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
Date: Mon, 9 Jan 2017 08:47:31 -0800 [thread overview]
Message-ID: <a8f38ecb-f85e-4fa4-5bd6-4511cdfe3ab0@infradead.org> (raw)
In-Reply-To: <87d1fwurbw.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 01/09/17 08:32, Vivien Didelot wrote:
> Hi Randy,
>
> Randy Dunlap <rdunlap@infradead.org> writes:
>
>> On 01/08/17 17:18, Florian Fainelli wrote:
>>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>>
>>>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>>>
>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>>
>>
>> but when CONFIG_INET is not enabled, the patch causes this warning:
>>
>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>
> Thanks for spotting that! Would that be enough to change this first?
>
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index 675acbf1502d..c7263b70e72b 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -1,6 +1,6 @@
> config HAVE_NET_DSA
> def_bool y
> - depends on NETDEVICES && !S390
> + depends on INET && NETDEVICES && !S390
>
> # Drivers must select NET_DSA and the appropriate tagging format
Yes, thanks.
Tested-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
prev parent reply other threads:[~2017-01-09 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 23:17 [PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot
2017-01-08 23:31 ` Andrew Lunn
2017-01-09 1:18 ` Florian Fainelli
2017-01-09 1:32 ` Randy Dunlap
2017-01-09 16:32 ` Vivien Didelot
2017-01-09 16:47 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8f38ecb-f85e-4fa4-5bd6-4511cdfe3ab0@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).