From: Balbir Singh <bsingharora@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
akpm@linux-foundation.org, benh@au1.ibm.com,
michaele@au1.ibm.com, michael.neuling@au1.ibm.com,
paulus@au1.ibm.com, "Kirill A . Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw
Date: Mon, 14 Nov 2016 17:07:37 +1100 [thread overview]
Message-ID: <a8ff3bc4-45f8-fc3c-2ffe-7d25ce259513@gmail.com> (raw)
In-Reply-To: <20161113150025.17942-1-aneesh.kumar@linux.vnet.ibm.com>
On 14/11/16 02:00, Aneesh Kumar K.V wrote:
> Architectures like ppc64 want to use page table deposit/withraw
> even with huge pmd dax entries. Allow arch to override the
> vma_is_anonymous check by moving that to pmd_move_must_withdraw
> function
>
I think the changelog can be reworded a bit
Independent of whether the vma is for anonymous memory, some arches
like ppc64 would like to override pmd_move_must_withdraw(). One option
is to encapsulate the vma_is_anonymous() check for general architectures
inside pmd_move_must_withdraw() so that is always called and architectures
that need unconditional overriding can override this function. ppc64
needs to override the function when the MMU is configured to use hash
PTE's.
What do you think?
Balbir Singh.
next prev parent reply other threads:[~2016-11-14 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 15:00 [PATCH V3 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw Aneesh Kumar K.V
2016-11-13 15:00 ` [PATCH V3 2/2] mm: THP page cache support for ppc64 Aneesh Kumar K.V
2016-11-14 2:11 ` Kirill A. Shutemov
2016-11-14 6:07 ` Balbir Singh [this message]
2016-11-14 8:57 ` [PATCH V3 1/2] mm: move vma_is_anonymous check within pmd_move_must_withdraw mpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8ff3bc4-45f8-fc3c-2ffe-7d25ce259513@gmail.com \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@au1.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael.neuling@au1.ibm.com \
--cc=michaele@au1.ibm.com \
--cc=paulus@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).