From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: vnkgutta@codeaurora.org
Cc: Borislav Petkov <bp@alien8.de>,
evgreen@chromium.org, robh@kernel.org, mchehab@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, tsoni@codeaurora.org,
ckadabi@codeaurora.org, rishabhb@codeaurora.org,
swboyd@chromium.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs
Date: Tue, 11 Sep 2018 15:11:30 +0530 [thread overview]
Message-ID: <a8fff11e-5821-f191-ed2e-ec99fadcb5e6@codeaurora.org> (raw)
In-Reply-To: <b5d9a1dc741e09db6d4044f4d82f83d9@codeaurora.org>
On 9/11/2018 4:15 AM, vnkgutta@codeaurora.org wrote:
> On 2018-09-06 22:02, Sai Prakash Ranjan wrote:
>> On 9/7/2018 4:01 AM, vnkgutta@codeaurora.org wrote:
>>> On 2018-09-06 05:38, Sai Prakash Ranjan wrote:
>>>> On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote:
>>>>> +static const struct of_device_id qcom_llcc_edac_match_table[] = {
>>>>> + { .compatible = "qcom,llcc-edac" },
>>>>> + { },
>>>>> +};
>>>>> +
>>>>>
>>>> Hi Venkata,
>>>>
>>>> Devicetree binding for llcc is updated, but what about this compatible?
>>>
>>> Does it need documentation too? I was not sure if I should add
>>> documentation for this or not!
>>>
>>
>> It does not require a separate binding, what I meant was to add this
>> compatible in the llcc binding itself, maybe as a subnode if it is
>> correct.
>
> Hi,
>
> We aren't really using this of_device_id structure, as this driver is
> being registered from LLCC through
> platform_register_device_data(...). This structure initialization is
> just dead code as this driver won't be probed based on the DT entries.
>
> Hence removing this compatible property and the corresponding struct in
> the next patchset.
>
> So, this doesn't need an extra binding/documentation.
Ok. Now that you have removed the compatible, it should be fine.
Thanks
next prev parent reply other threads:[~2018-09-11 9:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 23:22 [PATCH v4 0/4] Add EDAC driver for QCOM SoCs Venkata Narendra Kumar Gutta
2018-09-04 23:22 ` [PATCH v4 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC) Venkata Narendra Kumar Gutta
2018-09-04 23:22 ` [PATCH v4 2/4] drivers: soc: Add support to register LLCC EDAC driver Venkata Narendra Kumar Gutta
2018-09-04 23:22 ` [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs Venkata Narendra Kumar Gutta
2018-09-06 12:38 ` Sai Prakash Ranjan
2018-09-06 22:31 ` vnkgutta
2018-09-07 5:02 ` Sai Prakash Ranjan
2018-09-10 22:45 ` vnkgutta
2018-09-11 9:41 ` Sai Prakash Ranjan [this message]
2018-09-07 8:18 ` Borislav Petkov
2018-09-04 23:22 ` [PATCH v4 4/4] dt-bindings: msm: Update documentation of qcom,llcc Venkata Narendra Kumar Gutta
2018-09-06 13:16 ` Sai Prakash Ranjan
2018-09-06 22:43 ` vnkgutta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8fff11e-5821-f191-ed2e-ec99fadcb5e6@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=bp@alien8.de \
--cc=ckadabi@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=rishabhb@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
--cc=tsoni@codeaurora.org \
--cc=vnkgutta@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).