From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbdCIWKN (ORCPT ); Thu, 9 Mar 2017 17:10:13 -0500 Received: from smtp35.i.mail.ru ([94.100.177.95]:37062 "EHLO smtp35.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751875AbdCIWKM (ORCPT ); Thu, 9 Mar 2017 17:10:12 -0500 Subject: Re: [v6 PATCH 00/21] x86: Enable User-Mode Instruction Prevention To: Ricardo Neri , Andy Lutomirski References: <20170308003254.27833-1-ricardo.neri-calderon@linux.intel.com> <79ba0fff-4c01-2bfa-06cb-5cfc98dd710c@list.ru> <997ba581-ecfa-b773-a48e-85b92a439836@list.ru> <1489022122.131264.33.camel@ranerica-desktop> Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andy Lutomirski , Borislav Petkov , Peter Zijlstra , Andrew Morton , Brian Gerst , Chris Metcalf , Dave Hansen , Paolo Bonzini , Liang Z Li , Masami Hiramatsu , Huang Rui , Jiri Slaby , Jonathan Corbet , "Michael S. Tsirkin" , Paul Gortmaker , Vlastimil Babka , Chen Yucong , Alexandre Julliard , Fenghua Yu , "Ravi V. Shankar" , Shuah Khan , "linux-kernel@vger.kernel.org" , X86 ML , linux-msdos@vger.kernel.org, wine-devel@winehq.org From: Stas Sergeev Message-ID: Date: Fri, 10 Mar 2017 01:10:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1489022122.131264.33.camel@ranerica-desktop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp35.i.mail.ru; auth=pass smtp.auth=stsp@list.ru smtp.mailfrom=stsp@list.ru X-7FA49CB5: 0D63561A33F958A5C8C8F9D0BEB056D8C528E96BD6252BDB18DE8D2CDBF127BB9F18ECD7E95F35E929AFE063DF4C541C4A47138694635AE8D7C7A2C6549146180BF2EBBBDD9D6B0F700B7D52D678FF46 X-Mailru-Sender: F1845AB6CCC9920DF7838D61D4D05C42FD8808B4CBFE3C6FF1FDF9CD5A3CF1E30F5EBBCEE059CC241653177920737CA72999BEE114A20FF4278B2D54D4112F244F0A872F021F905956A8FB0C6EBA5FCCEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: OK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 09.03.2017 04:15, Ricardo Neri пишет: > On Wed, 2017-03-08 at 08:46 -0800, Andy Lutomirski wrote: >> On Wed, Mar 8, 2017 at 8:29 AM, Stas Sergeev wrote: >>> 08.03.2017 19:06, Andy Lutomirski пишет: >>>> On Wed, Mar 8, 2017 at 6:08 AM, Stas Sergeev wrote: >>>>> 08.03.2017 03:32, Ricardo Neri пишет: >>>>>> These are the instructions covered by UMIP: >>>>>> * SGDT - Store Global Descriptor Table >>>>>> * SIDT - Store Interrupt Descriptor Table >>>>>> * SLDT - Store Local Descriptor Table >>>>>> * SMSW - Store Machine Status Word >>>>>> * STR - Store Task Register >>>>>> >>>>>> This patchset initially treated tasks running in virtual-8086 >> mode as a >>>>>> special case. However, I received clarification that DOSEMU[8] >> does not >>>>>> support applications that use these instructions. >>>> Can you remind me what was special about it? It looks like you >> still >>>> emulate them in v8086 mode. >>> Indeed, sorry, I meant prot mode here. :) >>> So I wonder what was cited to be special about v86. > Initially my patches disabled UMIP on virtual-8086 instructions, without > regards of protected mode (i.e., UMIP was always enabled). I didn't have > emulation at the time. Then, I added emulation code that now covers > protected and virtual-8086 modes. I guess it is not special anymore. But isn't SLDT&friends just throw UD in v86? How does UMIP affect this? How does your patch affect this?