linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philippe CORNU <philippe.cornu@st.com>
To: Yannick FERTRE <yannick.fertre@st.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH] drm/panel: otm8009a: set clock to 29.70 Mhz
Date: Tue, 26 Mar 2019 12:50:24 +0000	[thread overview]
Message-ID: <a9072186-51ac-ac76-c544-02785c726846@st.com> (raw)
In-Reply-To: <1553155646-13636-1-git-send-email-yannick.fertre@st.com>

Dear Yannick,
Many thanks for your patch.

Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Tested-by: Philippe Cornu <philippe.cornu@st.com>

Philippe :-)


On 3/21/19 9:07 AM, Yannick Fertré wrote:
> The panel does not support clock frequency over 30.74 Mhz.
> The clock rate has been reduced to 29.70 Mhz & new timings have
> been computed to get a framerate of 50fps.
> 
> Signed-off-by: Yannick Fertré <yannick.fertre@st.com>
> ---
>   drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index 87fa316..f715bbe 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -67,15 +67,15 @@ struct otm8009a {
>   };
>   
>   static const struct drm_display_mode default_mode = {
> -	.clock = 32729,
> +	.clock = 29700,
>   	.hdisplay = 480,
> -	.hsync_start = 480 + 120,
> -	.hsync_end = 480 + 120 + 63,
> -	.htotal = 480 + 120 + 63 + 120,
> +	.hsync_start = 480 + 98,
> +	.hsync_end = 480 + 98 + 32,
> +	.htotal = 480 + 98 + 32 + 98,
>   	.vdisplay = 800,
> -	.vsync_start = 800 + 12,
> -	.vsync_end = 800 + 12 + 12,
> -	.vtotal = 800 + 12 + 12 + 12,
> +	.vsync_start = 800 + 15,
> +	.vsync_end = 800 + 15 + 10,
> +	.vtotal = 800 + 15 + 10 + 14,
>   	.vrefresh = 50,
>   	.flags = 0,
>   	.width_mm = 52,
> 

  reply	other threads:[~2019-03-26 12:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  8:07 [PATCH] drm/panel: otm8009a: set clock to 29.70 Mhz Yannick Fertré
2019-03-26 12:50 ` Philippe CORNU [this message]
2019-04-03 16:25 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9072186-51ac-ac76-c544-02785c726846@st.com \
    --to=philippe.cornu@st.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=thierry.reding@gmail.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).