From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86AC3C35242 for ; Fri, 14 Feb 2020 20:49:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5308024670 for ; Fri, 14 Feb 2020 20:49:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="SarBqj+o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389551AbgBNUt1 (ORCPT ); Fri, 14 Feb 2020 15:49:27 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45273 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389194AbgBNUtX (ORCPT ); Fri, 14 Feb 2020 15:49:23 -0500 Received: by mail-wr1-f66.google.com with SMTP id g3so12447617wrs.12 for ; Fri, 14 Feb 2020 12:49:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BG/k+1n242XmQ392+l/+QM8WpV3CVNW+mSgRrXUNaOk=; b=SarBqj+oUxptfwZyuPnoE9f5TdNLgDfCHQUMJ/hlsyT34Ix7OOciJH7CP+Ir3b2GzM 9zb3YRPgjRMX5OrfVnsaU+NWX65BwvyfNy/jlvmnZvXwHmUhKJyKKN4i2ekuDyB+AUaN m0OvEgnVfVGPMiW73eqXyVcabZ6/knDSWdzPA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BG/k+1n242XmQ392+l/+QM8WpV3CVNW+mSgRrXUNaOk=; b=hLeet7lD6XA72Wc6iNtlnuemNFUCRjlh/ax3cryln5IOVaqk/peEW0YpWITgxNvf3G Y0cNRIYNRhOVominKJh2uXiEESUk8rijX2VZedTv4rMpzsWp6+kHEEmxOOMPL79vK9CN okl6HW7O86WWPqZE4Zv2hZGFn3VzfCQl9mLFEUpIucqvIMDtuSNopmj7A6c7eik66x5y j4GXzPyWu2Dj/VGIjC+TJ1KNVuTOxN86FNr+w3cFNeeWMyviX1MQF8M0b7G6cjnTu/9P TMTuCEQnjCc7SZ5NinBFCbySqTKbCyj2PEBNOnsrzWp4eUDSdoZ9igW8tm4Nf+38exAb SHsQ== X-Gm-Message-State: APjAAAW7UiMgY89Wox6ER8kMlUhVAP1IBo/BBWole/iy97FiGFy4a6so US73WtvbZyTBbB4kD0CL4YwvDg== X-Google-Smtp-Source: APXvYqxncTdduvArrIOwd2nDXfNPYclGCAutEyIXX9NPCJWgKiNMBPvLCR/gffpuMOaRVYxDiBFUkg== X-Received: by 2002:adf:e74a:: with SMTP id c10mr6152109wrn.254.1581713361497; Fri, 14 Feb 2020 12:49:21 -0800 (PST) Received: from [192.168.1.149] (ip-5-186-115-54.cgn.fibianet.dk. [5.186.115.54]) by smtp.gmail.com with ESMTPSA id r6sm8400054wrp.95.2020.02.14.12.49.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2020 12:49:20 -0800 (PST) Subject: Re: [PATCH AUTOSEL 4.9 003/141] soc: fsl: qe: change return type of cpm_muram_alloc() to s32 To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Timur Tabi , Li Yang , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy References: <20200214162122.19794-1-sashal@kernel.org> <20200214162122.19794-3-sashal@kernel.org> From: Rasmus Villemoes Message-ID: Date: Fri, 14 Feb 2020 21:49:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200214162122.19794-3-sashal@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2020 17.19, Sasha Levin wrote: > From: Rasmus Villemoes > > [ Upstream commit 800cd6fb76f0ec7711deb72a86c924db1ae42648 ] Hmm. Please note that these two autosel patches were part of a giant 48-patch series. While not all depending on each other, there are definitely some dependencies, and between 800cd6fb76f0 and 148587a59f6b there is e.g. be2e9415f8b3 which changes the type used to store the return value from cpm_muram_alloc(), and a whole lot of other cpm_muram_alloc() refactorings and cleanups - one of which (b6231ea2b3c6) caused a regression on ppc 8xx. So I think taking just these two might not work as expected, but taking even more from that series is quite error-prone. Unless someone speaks up and explicitly points out and verifies some specific subset of the patches for a specific stable tree, I think they should not be added to any -stable kernel. [FWIW, we use the whole series backported to 4.19.y on both arm and ppc platforms, but as the b6231ea2b3c6 case showed, that doesn't really prove there are no problems cherry-picking these]. Rasmus