From: Joe Lawrence <joe.lawrence@redhat.com>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>, linux-kselftest@vger.kernel.org
Cc: shuah@kernel.org, sboyd@kernel.org, tglx@linutronix.de,
john.stultz@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] selftests/timers: Turn off timeout setting
Date: Thu, 27 Feb 2020 10:02:58 -0500 [thread overview]
Message-ID: <a93abb42-ec5b-5407-6c45-c888f6f9dc5e@redhat.com> (raw)
In-Reply-To: <20200225165749.6399-1-po-hsu.lin@canonical.com>
On 2/25/20 11:57 AM, Po-Hsu Lin wrote:
> The following 4 tests in timers can take longer than the default 45
> seconds that added in commit 852c8cbf (selftests/kselftest/runner.sh:
> Add 45 second timeout per test) to run:
> * nsleep-lat - 2m7.350s
> * set-timer-lat - 2m0.66s
> * inconsistency-check - 1m45.074s
> * raw_skew - 2m0.013s
>
> Thus they will be marked as failed with the current 45s setting:
> not ok 3 selftests: timers: nsleep-lat # TIMEOUT
> not ok 4 selftests: timers: set-timer-lat # TIMEOUT
> not ok 6 selftests: timers: inconsistency-check # TIMEOUT
> not ok 7 selftests: timers: raw_skew # TIMEOUT
>
> Disable the timeout setting for timers can make these tests finish
> properly:
> ok 3 selftests: timers: nsleep-lat
> ok 4 selftests: timers: set-timer-lat
> ok 6 selftests: timers: inconsistency-check
> ok 7 selftests: timers: raw_skew
>
> https://bugs.launchpad.net/bugs/1864626
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
> tools/testing/selftests/timers/Makefile | 1 +
> tools/testing/selftests/timers/settings | 1 +
> 2 files changed, 2 insertions(+)
> create mode 100644 tools/testing/selftests/timers/settings
>
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index 7656c7c..0e73a16 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
>
> TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)
>
> +TEST_FILES := settings
>
> include ../lib.mk
>
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
>
v2 changes LGTM..
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
-- Joe
next prev parent reply other threads:[~2020-02-27 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 16:57 [PATCHv2] selftests/timers: Turn off timeout setting Po-Hsu Lin
2020-02-27 15:02 ` Joe Lawrence [this message]
2020-03-13 17:41 ` shuah
2020-04-06 6:24 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a93abb42-ec5b-5407-6c45-c888f6f9dc5e@redhat.com \
--to=joe.lawrence@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=po-hsu.lin@canonical.com \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).